Differential D7811

misc/coverage: Add a focus query parameter to emphasize origin types
ClosedPublic
Actions

Authored by anlambert on May 11 2022, 12:07 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T3117: Publish status of existing listers and loaders

Commits

rDWAPPSd92988fa24b3: misc/coverage: Add a focus query parameter to emphasize origin types

Summary

When that parameter is used, the lists of origin types it contains will
be emphasized in the archive coverage view by adding a red border around
the associated bootstrap cards.

Cards content will also be expanded by default and no maximum height
will be applied.

The purpose is to emphasize the result of a given lister. Such links
will be made available in the documentation page compiling the current
statuses of available listers.

Related to T3117

Diff Detail

Repository

rDWAPPS Web applications

Branch

coverage-focus

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 29276
Build 45770: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 45769: arc lint + arc unit

Event Timeline

anlambert created this revision.May 11 2022, 12:07 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 11 2022, 12:07 PM

Build has FAILED

Patch application report for D7811 (id=28212)

Rebasing onto fdaaa3a24c...

Current branch diff-target is up to date.

Changes applied before test

commit ef93416c4cd2411ab0a8dc91789f90fd0fcf69db
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue May 10 16:36:50 2022 +0200

    misc/coverage: Add a focus query parameter to emphasize origin types
    
    When that parameter is used, the lists of origin types it contains will
    be emphasized in the archive coverage view by adding a red border around
    the associated bootstrap cards.
    
    Cards content will also be expanded by default and no maximum height
    will be applied.
    
    The purpose is to emphasize the result of a given lister. Such links
    will be made available in the documentation page compiling the current
    statuses of available listers.
    
    Related to T3117

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1825/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1825/console

Harbormaster returned this revision to the author for changes because remote builds failed.May 11 2022, 12:28 PM

Harbormaster failed remote builds in B29275: Diff 28212!

Fix test

Build is green

Patch application report for D7811 (id=28213)

Rebasing onto fdaaa3a24c...

Current branch diff-target is up to date.

Changes applied before test

commit d92988fa24b3ad276b0b5b3b46a72f162fe6eea6
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue May 10 16:36:50 2022 +0200

    misc/coverage: Add a focus query parameter to emphasize origin types
    
    When that parameter is used, the lists of origin types it contains will
    be emphasized in the archive coverage view by adding a red border around
    the associated bootstrap cards.
    
    Cards content will also be expanded by default and no maximum height
    will be applied.
    
    The purpose is to emphasize the result of a given lister. Such links
    will be made available in the documentation page compiling the current
    statuses of available listers.
    
    Related to T3117

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1826/ for more details.

Harbormaster completed remote builds in B29276: Diff 28213.May 11 2022, 12:51 PM

anlambert requested review of this revision.May 11 2022, 12:51 PM