api/raw: Ensure to ignore display names in raw object endpoint
ClosedPublic
Actions

Authored by anlambert on May 10 2022, 3:31 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T4226: Restrict the query of /raw/(swhid)/ Web API endpoint to privileged users

Commits

rDWAPPSfdaaa3a24ca5: api/raw: Ensure to ignore display names in raw object endpoint

Summary

The sha1 hash from the returned raw manifest for revision and
release might differ from object id otherwise.

Related to T4226

Test Plan

I tried to add a test for this but the sync_mailmap django command
works only for postgresql storage and the webapp tests use a memory
storage so we cannot setup mailmaps here.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.May 10 2022, 3:31 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 10 2022, 3:31 PM

Build is green

Patch application report for D7804 (id=28190)

Rebasing onto 3fc9c9276c...

Current branch diff-target is up to date.

Changes applied before test

commit 3202cb063a7a6c254d99b8b2bf56e63a55932068
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue May 10 15:26:50 2022 +0200

    api/raw: Ensure to ignore display names in raw object endpoint
    
    The sha1 hash from the returned raw manifest for revision and
    release might differ from object id otherwise.
    
    Related to T4226

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1820/ for more details.

Harbormaster completed remote builds in B29252: Diff 28190.May 10 2022, 3:55 PM

anlambert requested review of this revision.May 10 2022, 3:55 PM

vlorentz accepted this revision.May 10 2022, 3:57 PM

This revision is now accepted and ready to land.May 10 2022, 3:57 PM

Rebase

This revision was landed with ongoing or failed builds.May 11 2022, 10:52 AM

Closed by commit rDWAPPSfdaaa3a24ca5: api/raw: Ensure to ignore display names in raw object endpoint (authored by anlambert). · Explain Why

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSfdaaa3a24ca5: api/raw: Ensure to ignore display names in raw object endpoint.

Build is green

Patch application report for D7804 (id=28209)

Rebasing onto 080c988fe9...

Current branch diff-target is up to date.

Changes applied before test

commit fdaaa3a24ca53bdce246d1737f455b682a5a76a7
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue May 10 15:26:50 2022 +0200

    api/raw: Ensure to ignore display names in raw object endpoint
    
    The sha1 hash from the returned raw manifest for revision and
    release might differ from object id otherwise.
    
    Related to T4226

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1824/ for more details.

Harbormaster completed remote builds in B29272: Diff 28209.May 11 2022, 11:13 AM