Page MenuHomeSoftware Heritage

api/raw: Ensure to ignore display names in raw object endpoint
ClosedPublic

Authored by anlambert on Tue, May 10, 3:31 PM.

Details

Summary

The sha1 hash from the returned raw manifest for revision and
release might differ from object id otherwise.

Related to T4226

Test Plan

I tried to add a test for this but the sync_mailmap django command
works only for postgresql storage and the webapp tests use a memory
storage so we cannot setup mailmaps here.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7804 (id=28190)

Rebasing onto 3fc9c9276c...

Current branch diff-target is up to date.
Changes applied before test
commit 3202cb063a7a6c254d99b8b2bf56e63a55932068
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue May 10 15:26:50 2022 +0200

    api/raw: Ensure to ignore display names in raw object endpoint
    
    The sha1 hash from the returned raw manifest for revision and
    release might differ from object id otherwise.
    
    Related to T4226

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1820/ for more details.

This revision is now accepted and ready to land.Tue, May 10, 3:57 PM
This revision was landed with ongoing or failed builds.Wed, May 11, 10:52 AM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D7804 (id=28209)

Rebasing onto 080c988fe9...

Current branch diff-target is up to date.
Changes applied before test
commit fdaaa3a24ca53bdce246d1737f455b682a5a76a7
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue May 10 15:26:50 2022 +0200

    api/raw: Ensure to ignore display names in raw object endpoint
    
    The sha1 hash from the returned raw manifest for revision and
    release might differ from object id otherwise.
    
    Related to T4226

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1824/ for more details.