Details

Reviewers

bchauvet
anlambert

Maniphest Tasks

T4223: Apply GitLab new logo

Commits

rDWAPPSf94c528e55ad: Updated the Gitlab Logo

Summary

Updated the Logo for GitLab
Related to T4223

Diff Detail

Repository

rDWAPPS Web applications

Branch

new-logo

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 29386
Build 45922: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 45921: arc lint + arc unit

Event Timeline

anirudhlakhotia created this revision.May 10 2022, 11:36 AM

Build is green

Patch application report for D7796 (id=28165)

Rebasing onto b084e4b15e...

First, rewinding head to replay your work on top of it...
Applying: Updated Gitlab Logo

Changes applied before test

commit 342cbc4816011a5791b84f484925276799bdd984
Author: anirudhlakhotia <sanjeev196945@gmail.com>
Date:   Tue May 10 15:04:01 2022 +0530

    Updated Gitlab Logo

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1812/ for more details.

Harbormaster completed remote builds in B29231: Diff 28165.May 10 2022, 11:58 AM

anirudhlakhotia requested review of this revision.May 10 2022, 11:58 AM

Thanks ! Please crop some vertical and horizontal space around the logo using gimp as currently the rendering is not great.
The gitlab logo looks really small compared to the others.

This revision now requires changes to proceed.May 11 2022, 2:45 PM

Updated Gitlab Logo

Could you please check the rendering now?
I modified it using GIMP, but added space to the image to reduce the size on the page.

It looks like this without the added space for reference.

Build is green

Patch application report for D7796 (id=28281)

Could not rebase; Attempt merge onto 8abf69c7dc...

Merge made by the 'recursive' strategy.
 static/img/logos/gitlab.png | Bin 11983 -> 20054 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)

Changes applied before test

commit 0e9d9602fc8a101e810dd089ebe1975dc0513e0f
Merge: 8abf69c7 5a5ee03a
Author: Jenkins user <jenkins@localhost>
Date:   Fri May 13 16:26:43 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 5a5ee03a21dfd823b839905bf86a4e8c67537ef2
Author: anirudhlakhotia <sanjeev196945@gmail.com>
Date:   Fri May 13 21:54:38 2022 +0530

    Updated Gitlab Logo

commit 60d0577420f3263319085e1dab31039ac24ff240
Author: anirudhlakhotia <sanjeev196945@gmail.com>
Date:   Tue May 10 15:04:01 2022 +0530

    Updated Gitlab Logo

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1839/ for more details.

Harbormaster completed remote builds in B29386: Diff 28281.May 13 2022, 6:46 PM

add_forge_now: Sanitized URLs on moderation dashboard
Sanitized the URLs in the Forge URL column of the datatable and added a clickable icon to open the links in a new tab

Related to T4246

Updated Gitlab Logo

Related to T4223

Build has FAILED

Patch application report for D7796 (id=28283)

Rebasing onto 8abf69c7dc...

First, rewinding head to replay your work on top of it...
Applying: Updated Gitlab Logo
Applying: Updated Gitlab Logo
Applying: Sanitized URLs on moderation dashboard

Changes applied before test

commit a09467b2a28b06328de2f78fd901ed412451bb3d
Author: anirudhlakhotia <sanjeev196945@gmail.com>
Date:   Sat May 14 18:33:57 2022 +0530

    Sanitized URLs on moderation dashboard

commit 55f03f80cbe5dabedcbe8b2186873f34d9e2329f
Author: anirudhlakhotia <sanjeev196945@gmail.com>
Date:   Fri May 13 21:54:38 2022 +0530

    Updated Gitlab Logo

commit c360a4478aab7e1bf18113d06ffbc57523def3b9
Author: anirudhlakhotia <sanjeev196945@gmail.com>
Date:   Tue May 10 15:04:01 2022 +0530

    Updated Gitlab Logo

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1840/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1840/console

Harbormaster failed remote builds in B29391: Diff 28283!May 14 2022, 3:26 PM

Build is green

Patch application report for D7796 (id=28284)

Could not rebase; Attempt merge onto 8abf69c7dc...

Merge made by the 'recursive' strategy.
 static/img/logos/gitlab.png | Bin 11983 -> 20054 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)

Changes applied before test

commit 06ec4a927db099741e291a5c19395c72298cdde1
Merge: 8abf69c7 5a5ee03a
Author: Jenkins user <jenkins@localhost>
Date:   Sat May 14 13:15:33 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 5a5ee03a21dfd823b839905bf86a4e8c67537ef2
Author: anirudhlakhotia <sanjeev196945@gmail.com>
Date:   Fri May 13 21:54:38 2022 +0530

    Updated Gitlab Logo

commit 60d0577420f3263319085e1dab31039ac24ff240
Author: anirudhlakhotia <sanjeev196945@gmail.com>
Date:   Tue May 10 15:04:01 2022 +0530

    Updated Gitlab Logo

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1841/ for more details.

Harbormaster completed remote builds in B29392: Diff 28284.May 14 2022, 3:36 PM

Updated the Gitlab Logo

Related to T4223

Build is green

Patch application report for D7796 (id=28289)

Rebasing onto 8abf69c7dc...

First, rewinding head to replay your work on top of it...
Applying: Updated Gitlab Logo
Applying: Updated Gitlab Logo
Applying: search: Allow to pass empty pattern when searching for origins
Using index info to reconstruct a base tree...
M	assets/src/bundles/browse/origin-search.js
M	cypress/integration/origin-search.spec.js
M	swh/web/api/views/origin.py
M	swh/web/templates/includes/origin-search-form.html
M	swh/web/tests/api/views/test_origin.py
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
Applying: templates/content-display: Check content rendering for mime type first
Using index info to reconstruct a base tree...
M	cypress/integration/content-rendering.spec.js
M	swh/web/templates/includes/content-display.html
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
Applying: api/throttling: Fix save code now throttle scope name
Using index info to reconstruct a base tree...
M	swh/web/api/throttling.py
M	swh/web/settings/tests.py
M	swh/web/tests/api/views/test_origin_save.py
Falling back to patching base and 3-way merge...
Auto-merging swh/web/settings/tests.py
CONFLICT (content): Merge conflict in swh/web/settings/tests.py
Auto-merging swh/web/api/throttling.py
Patch failed at 0005 api/throttling: Fix save code now throttle scope name

Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".

Rebase failed (ret=1)!

Could not rebase; Attempt merge onto 8abf69c7dc...

Already up to date.

Changes applied before test

commit 9e852cecb50fe8371ce412ec1af39df39816a22d
Author: anirudhlakhotia <sanjeev196945@gmail.com>
Date:   Sat May 14 20:40:07 2022 +0530

    Updated the Gitlab Logo

commit 565f37a44ffbe0716fd95f23209389aa13dba296
Author: anirudhlakhotia <sanjeev196945@gmail.com>
Date:   Sat May 14 20:33:08 2022 +0530

    Updated GitLab Logo

commit 829b809ab8d76ebbb65c814e1038686e9ec111ee
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri May 13 11:59:59 2022 +0200

    package.json: Upgrade dependencies

commit 204dc57f74a723bdc46fa590b2700abf2077ce0a
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu May 12 18:10:45 2022 +0200

    misc/coverage: Fix some origins search links
    
    Search pattern for launchpad bzr origins was invalid.
    
    Use a more generic default search pattern for opam origins.
    
    Ensure to not generate search links for VCS origins produced
    by the maven lister as there is no generic search patterns
    here.
    
    Related to T3117

commit 9566b0a8aa7942cb7d2716d0e4dda3a75c8a7ecf
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu May 12 17:00:11 2022 +0200

    misc/coverage: Add counts for origins listed from Packagist
    
    The packagist lister has been executed on staging so we can add
    it to the list of origin types.
    
    That lister produces git, hg or svn origins from various forges
    so we cannot add search links for it.
    
    Related to T3117

commit 0f89145ed90732bff26787cdc9e7bc961dad3dfa
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu May 12 17:39:02 2022 +0200

    assets/admin/deposits: Remove deposits filtering by user for non staff
    
    The deposits admin view is read only and there is no sensitive data
    displayed here so we can remove the deposits filtering by username
    for non staff users but with adequate permission.

commit aeee1707b6973e4885a43c094e330e2dc96e0f25
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu May 12 15:44:21 2022 +0200

    misc/coverage: Add counts for origins listed from maven repositories
    
    Listing and loading started on staging so we can add the associated
    counters in the archive coverage view.
    
    Those counters will not be displayed in production webapp until
    production deployment of maven lister and loader.
    
    Related to T3117

commit 81f2ea0ce63bde5052c33e3d902ffce7667bb267
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu May 12 15:15:28 2022 +0200

    misc/coverage: Update search pattern for sourceforge bzr/cvs origins
    
    The origin URLs for those visit types do not follow the same pattern
    as the git, hg and svn ones.
    
    Related to T3117

commit df1b2e493b7513f2936f7c5d945c2b405cd2e6b4
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu May 12 15:01:13 2022 +0200

    misc/coverage: Add count for origins listed from phabricator instances
    
    More origins seem to have been loaded since so let's integrate
    phabricator in the coverage list.
    
    Related to T3117

commit 53a45596cf16638ac2fbf29501b54fc8d3f890a1
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu May 12 14:49:10 2022 +0200

    misc/coverage: Improve display of origin counters in production/staging
    
    If the global counter for an origin type is equal to zero, do not display
    the bootstrap card for that origin type.
    
    If a visit type counter for an origin type is equal to zero, do not
    display it in the counters table for that origin type.
    
    It enables to not take into account origins that have been listed
    but not loaded without having to hardcode that information in
    coverage widget implementation.
    
    Also use origins_enabled field from scheduler metrics instead of
    origins_known one to compute the number of loaded origins per
    visit type.
    
    Related to T3117

commit 6df5915a4c4d5f98eb8358e1c787fdeee942a4b6
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue May 10 16:36:50 2022 +0200

    misc/coverage: Add a focus query parameter to emphasize origin types
    
    When that parameter is used, the lists of origin types it contains will
    be emphasized in the archive coverage view by adding a red border around
    the associated bootstrap cards.
    
    Cards content will also be expanded by default and no maximum height
    will be applied.
    
    The purpose is to emphasize the result of a given lister. Such links
    will be made available in the documentation page compiling the current
    statuses of available listers.
    
    Related to T3117

commit 421d83d85376f3b165d70eaa2616e95897a33efd
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue May 10 15:26:50 2022 +0200

    api/raw: Ensure to ignore display names in raw object endpoint
    
    The sha1 hash from the returned raw manifest for revision and
    release might differ from object id otherwise.
    
    Related to T4226

commit f16fc3f8671cb234317a2d1871c25622fd6ab42b
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue May 10 16:21:10 2022 +0200

    Add forge now: only catch expected exceptions in request dashboard
    
    The unqualified catch would hide all exceptions instead of only setting
    an error message when the request itself fails.

commit a4d2d96b37030f35b8463c346e6c33c4031c204e
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue May 10 16:20:57 2022 +0200

    Add forge now: process inbound emails
    
    Add a signal receiver to process inbound emails to the address set up in
    config. The text part of the emails is parsed if available, and the raw
    message is saved as a last resort.

commit 3fd9a854c2ceb94066cc4dd4ae827776a1571e9c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue May 10 16:20:46 2022 +0200

    Add forge now: set Cc and Reply-To for admin emails
    
    This sets the Cc and Reply-To headers to the email address for inbound
    message processing, when sending an email to the forge administrator.

commit d6baf2d91ab04009a74f057fe60b6dd585704823
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri May 6 18:36:48 2022 +0200

    Add forge now: add view to retrieve RequestHistory.message_source
    
    To access this view, one can follow the link inside RequestHistory API
    responses.

commit ce57e4c71f02cf90a7e7ff600f614184f333ed10
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Apr 1 17:08:47 2022 +0200

    Add forge now: prepare fields for inbound email processing
    
    - add message source field to request history table
    - add email as choice for the request history actor roles, when the
      message can't be matched to a known actor

commit ca01e85d1bf1b4affa74e7d4691930f697b754c5
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon May 9 16:22:59 2022 +0200

    api/raw: Restrict raw object endpoint use to privileged users
    
    As that endpoint can leak sensible information regarding authors in
    the archive, it has been decided to not make it publicly available.
    
    So restrict its use to staff users and users with new permission
    "swh.web.api.raw_object".
    
    Also lift rate limit on that new endpoint to ease development
    of the bridge of Software Heritage to IPFS.
    
    Related to T4226

commit 288edc081b8bc0b16431c1038a3559ee6f4c0fb5
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue May 10 11:59:31 2022 +0200

    add_forge_now: Improve HTML and harmonize display style
    
    Slightly rework HTML code related to add forge now feature in
    order to better integrate its UI into the webapp by:
    
      - using full width of bootstrap container for pages content
    
      - using bootstrap CSS classes when possible
    
      - removing useless DOM elements
    
      - wrapping long lines in HTML code

commit d6e1a7ce136cf5f7cf3c4f7c6d8afae6cc0d64b0
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue May 10 12:35:51 2022 +0200

    Add Forge Now: add a forge_domain property for use in templates
    
    This lets us generate more meaningful email subjects for request
    tracking, and will be useful for raw message filename generation too.

commit 2a18fcc5543c55ab42b58fad42863f4cce4ba67e
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Apr 1 10:38:38 2022 +0200

    Add forge now: add inbound email address to model

commit 6add65990c520c1f2d64fddf2f7752aef76c3960
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri May 6 16:38:37 2022 +0200

    common/utils: Display seconds by default in format_utc_iso_date
    
    It enables to disambiguate some dates in the Web UI (release ones for
    instance) only differing by the number of seconds.

commit e2abb80a6610b637467db4009a0efb215be1feb1
Author: Pratyush Desai <pratyush.desai@liberta.casa>
Date:   Mon May 9 12:14:20 2022 +0200

    add strict asyncio_mode in pytest.ini

commit f68fed98f09f2a6d15eb01d6a1e62da00efcd8f1
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon May 9 15:43:27 2022 +0200

    api/throttling: Fix save code now throttle scope name
    
    The scope name was missing the swh_ prefix, this was missed in tests
    due to an invalid rate value for POST requests (registered users can
    issue 10 times more requests that anonymous users).

commit c49ec9323f8581ae6cd7d719f74ff986fe32515a
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri May 6 14:31:59 2022 +0200

    templates/content-display: Check content rendering for mime type first
    
    The webapp can render some special content types (images, pdf) based on the
    mimetype of the currently browsed content object.
    
    However the checks of these mime types were done after the check for source
    code rendering which could lead to errors client side.

commit aa5c46427b1ade737d4cde804de387821c1011d2
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu May 5 10:38:19 2022 +0200

    search: Allow to pass empty pattern when searching for origins
    
    It enables to search for all origins or for all origins with a
    specific visit type.

commit 5a5ee03a21dfd823b839905bf86a4e8c67537ef2
Author: anirudhlakhotia <sanjeev196945@gmail.com>
Date:   Fri May 13 21:54:38 2022 +0530

    Updated Gitlab Logo

commit 60d0577420f3263319085e1dab31039ac24ff240
Author: anirudhlakhotia <sanjeev196945@gmail.com>
Date:   Tue May 10 15:04:01 2022 +0530

    Updated Gitlab Logo

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1842/ for more details.

Harbormaster completed remote builds in B29393: Diff 28289.May 14 2022, 5:33 PM

Updated the Gitlab Logo

Updated the Gitlab logo

Related to T4223

Build is green

Patch application report for D7796 (id=28290)

Rebasing onto 8abf69c7dc...

Current branch diff-target is up to date.

Changes applied before test

commit 9a0eb608b067ef1b4758f125341ee1e94351ce7a
Author: anirudhlakhotia <sanjeev196945@gmail.com>
Date:   Sun May 15 20:35:46 2022 +0530

    Updated the Gitlab Logo

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1843/ for more details.

Harbormaster completed remote builds in B29394: Diff 28290.May 15 2022, 5:27 PM

Looks good, thanks ! You will have to rebase the diff before landing it.

This revision is now accepted and ready to land.May 16 2022, 10:52 AM

Rebased the diff

Build is green

Patch application report for D7796 (id=28293)

Rebasing onto e49b84bcfb...

Current branch diff-target is up to date.

Changes applied before test

commit f94c528e55ad7e476546731b73bd2561a5f9e041
Author: anirudhlakhotia <sanjeev196945@gmail.com>
Date:   Sun May 15 20:35:46 2022 +0530

    Updated the Gitlab Logo

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1844/ for more details.

Harbormaster completed remote builds in B29397: Diff 28293.May 16 2022, 1:38 PM

Closed by commit rDWAPPSf94c528e55ad: Updated the Gitlab Logo (authored by anirudhlakhotia). · Explain WhyMay 16 2022, 5:32 PM

This revision was automatically updated to reflect the committed changes.

anirudhlakhotia added a commit: rDWAPPSf94c528e55ad: Updated the Gitlab Logo.

Updated Gitlab Logo
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Patch application report for D7796 (id=28165)

Changes applied before test

Patch application report for D7796 (id=28281)

Changes applied before test

Patch application report for D7796 (id=28283)

Changes applied before test

Patch application report for D7796 (id=28284)

Changes applied before test

Patch application report for D7796 (id=28289)

Changes applied before test

Patch application report for D7796 (id=28290)

Changes applied before test

Patch application report for D7796 (id=28293)

Changes applied before test

Revision Contents
Changeset List

Diff 28281

static/img/logos/gitlab.png

Updated Gitlab LogoClosedPublicActions

Details

Diff Detail

Event Timeline

Patch application report for D7796 (id=28165)

Changes applied before test

Patch application report for D7796 (id=28281)

Changes applied before test

Patch application report for D7796 (id=28283)

Changes applied before test

Patch application report for D7796 (id=28284)

Changes applied before test

Patch application report for D7796 (id=28289)

Changes applied before test

Patch application report for D7796 (id=28290)

Changes applied before test

Patch application report for D7796 (id=28293)

Changes applied before test

Revision ContentsChangeset List

Diff 28281

static/img/logos/gitlab.png

Updated Gitlab Logo
ClosedPublic
Actions

Revision Contents
Changeset List