diff --git a/swh/indexer/tests/test_metadata.py b/swh/indexer/tests/test_metadata.py --- a/swh/indexer/tests/test_metadata.py +++ b/swh/indexer/tests/test_metadata.py @@ -7,7 +7,6 @@ import unittest from hypothesis import HealthCheck, given, settings, strategies -import pytest from swh.indexer.codemeta import CODEMETA_TERMS from swh.indexer.metadata import ContentMetadataIndexer, RevisionMetadataIndexer @@ -406,41 +405,42 @@ }, ) - @pytest.mark.parametrize( - "filename", [b"package.json", b"Package.json", b"PACKAGE.json", b"PACKAGE.JSON"] - ) - def test_detect_metadata_package_json(self, filename): - # given - df = [ - { - "sha1_git": b"abc", - "name": b"index.js", - "target": b"abc", - "length": 897, - "status": "visible", - "type": "file", - "perms": 33188, - "dir_id": b"dir_a", - "sha1": b"bcd", - }, - { - "sha1_git": b"aab", - "name": filename, - "target": b"aab", - "length": 712, - "status": "visible", - "type": "file", - "perms": 33188, - "dir_id": b"dir_a", - "sha1": b"cde", - }, - ] - # when - results = detect_metadata(df) + def test_detect_metadata_package_json(self): + filenames = [b"package.json", b"Package.json", b"PACKAGE.json", b"PACKAGE.JSON"] - expected_results = {"NpmMapping": [b"cde"]} - # then - assert expected_results == results + for filename in filenames: + with self.subTest(filename=filename): + # given + df = [ + { + "sha1_git": b"abc", + "name": b"index.js", + "target": b"abc", + "length": 897, + "status": "visible", + "type": "file", + "perms": 33188, + "dir_id": b"dir_a", + "sha1": b"bcd", + }, + { + "sha1_git": b"aab", + "name": filename, + "target": b"aab", + "length": 712, + "status": "visible", + "type": "file", + "perms": 33188, + "dir_id": b"dir_a", + "sha1": b"cde", + }, + ] + # when + results = detect_metadata(df) + + expected_results = {"NpmMapping": [b"cde"]} + # then + self.assertEqual(expected_results, results) def test_detect_metadata_codemeta_json_uppercase(self): # given