Page MenuHomeSoftware Heritage
Differential D7764

icinga checks: Activate the prometheus export on e2e tests
ClosedPublic
Actions

Authored by vsellier on May 6 2022, 5:29 PM.

Details

Reviewers
olasd
ardumont
Group Reviewers
System administrators
Commits
rSPSITEa7c2fc6b65a1: icinga checks: Activate the prometheus export on e2e tests
Summary

Relative to T3129
Depends on D6926
Depends on D7844

Test Plan
  • no testable by octocatalog-diff because it's collected resources
  • no tested in vagrant because of vagrant issues

Diff Detail

Repository
rSPSITE puppet-swh-site
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vsellier created this revision.May 6 2022, 5:29 PM
Herald added a reviewer: System administrators. · View Herald TranscriptMay 6 2022, 5:29 PM
vsellier requested review of this revision.May 6 2022, 5:29 PM
Harbormaster completed remote builds in B29157: Diff 28085.May 6 2022, 5:29 PM
olasd accepted this revision.May 9 2022, 11:19 AM
olasd added a subscriber: olasd.

🤷🤷🤷 let's try it and see...

This revision is now accepted and ready to land.May 9 2022, 11:19 AM
ardumont accepted this revision.May 10 2022, 3:22 PM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
site-modules/profile/manifests/icinga2/objects/e2e_checks_deposit.pp
17

will the icinga check service have the right permission to write into that directory [1]?

[1]

prometheus::node::textfile_directory: /var/lib/prometheus/node-exporter
vsellier updated this revision to Diff 28338.May 17 2022, 8:42 PM
  • rebase
  • move the parameters after 'icinga_plugins'
  • add an environment parameter
Harbormaster completed remote builds in B29442: Diff 28338.May 17 2022, 8:42 PM
vsellier edited the summary of this revision. (Show Details)May 17 2022, 8:42 PM
vsellier added a parent revision: D7844: Allow icinga checks to write prometheus metrics files.
vsellier updated this revision to Diff 28390.May 19 2022, 2:18 PM

rebase

Harbormaster completed remote builds in B29485: Diff 28390.May 19 2022, 2:18 PM
Closed by commit rSPSITEa7c2fc6b65a1: icinga checks: Activate the prometheus export on e2e tests (authored by vsellier). · Explain WhyMay 19 2022, 2:43 PM
This revision was automatically updated to reflect the committed changes.
vsellier added a commit: rSPSITEa7c2fc6b65a1: icinga checks: Activate the prometheus export on e2e tests.

Revision Contents
Changeset List

PathSize
site-modules/
profile/
manifests/
icinga2/
objects/
7 lines
7 lines
7 lines

Diff 28391

View Options

site-modules/profile/manifests/icinga2/objects/e2e_checks_deposit.pp

Loading...
View Options

site-modules/profile/manifests/icinga2/objects/e2e_checks_savecodenow.pp

Loading...
View Options

site-modules/profile/manifests/icinga2/objects/e2e_checks_vault.pp

Loading...
About · Developer information · Legal