Page MenuHomeSoftware Heritage

Fix `api_swhid_known` when swhids share hash part
ClosedPublic

Authored by Ericson2314 on May 5 2022, 6:24 PM.

Details

Summary

We need to have separate sets for each type of object.

I have some other cleanups in minds, but this can fix the bug without
touching other repos for now.

Resolves T4224

Diff Detail

Repository
rDWAPPS Web applications
Branch
fix-T4224 (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 29098
Build 45492: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 45491: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D7748 (id=28018)

Rebasing onto 468dda170e...

Current branch diff-target is up to date.
Changes applied before test
commit 7fe72af05b4ce77b52eaf61e8a7b3bfe10ee4a8e
Author: John Ericson <John.Ericson@Obsidian.Systems>
Date:   Thu May 5 12:12:12 2022 -0400

    Fix T4224
    
    We need to have separate sets for each type of object.
    
    I have some other cleanups in minds, but this can fix the bug without
    touching other repos for now.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1782/ for more details.

vlorentz retitled this revision from Fix T4224 to Fix `api_swhid_known` when swhids share hash part.
vlorentz edited the summary of this revision. (Show Details)

thanks

This revision is now accepted and ready to land.May 5 2022, 7:22 PM

Build is green

Patch application report for D7748 (id=28022)

Rebasing onto 468dda170e...

Current branch diff-target is up to date.
Changes applied before test
commit 55122f0a2e2920de658b0c5bbc420a7612c78966
Author: John Ericson <John.Ericson@Obsidian.Systems>
Date:   Thu May 5 12:12:12 2022 -0400

    Fix `api_swhid_known` when swhids share hash part
    
    Bug: https://forge.softwareheritage.org/T4224
    
    We need to have separate sets for each type of object.
    
    I have some other cleanups in minds, but this can fix the bug without
    touching other repos for now.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1785/ for more details.