Differential D7738

Makefile: only try to run docs/% targets if the Makefile exists
ClosedPublic
Actions

Authored by olasd on May 4 2022, 3:07 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDENV92e599d92bd9: Makefile: only try to run docs/% targets if the Makefile exists

Summary

swh-docs build will break if the docs/ directory of a submodule does
not exist, even if the submodule is not hooked up to the docs build yet.

Test Plan

tox -e sphinx-dev in swh-docs

Diff Detail

Repository

rDENV Development environment

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 29064
Build 45434: arc lint + arc unit

Event Timeline

olasd created this revision.May 4 2022, 3:07 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 4 2022, 3:07 PM

olasd requested review of this revision.May 4 2022, 3:07 PM

Harbormaster completed remote builds in B29064: Diff 27986.May 4 2022, 3:07 PM

Seems safer indeed, thanks.

This revision is now accepted and ready to land.May 4 2022, 3:09 PM

Closed by commit rDENV92e599d92bd9: Makefile: only try to run docs/% targets if the Makefile exists (authored by olasd). · Explain WhyMay 4 2022, 3:15 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDENV92e599d92bd9: Makefile: only try to run docs/% targets if the Makefile exists.

Revision Contents
Changeset List

Path

Size

Makefile

8 lines

Diff 27986

View Options

Makefile: only try to run docs/% targets if the Makefile existsClosedPublicActions