Encountered issues have been fixed so we can remove the pinning of sphinx.
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T3872: Add support for Sphinx 4.4.0
- Commits
- rDDOC1be5975ec6bd: gitignore: Add apidoc folder
rDDOC29c11a7a0c73: requirements.txt: Remove sphinx version pin
Diff Detail
- Repository
- rDDOC Development documentation
- Branch
- remove-sphinx-pin
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 29163 Build 45596: Phabricator diff pipeline on Jenkins for swh-docs Jenkins console · Jenkins Build 45595: arc lint + arc unit
Event Timeline
Build has FAILED
Patch application report for D7731 (id=27957)
Rebasing onto 551fd26636...
Current branch diff-target is up to date.
Changes applied before test
commit 32fa29a5238845c9a696d6e80d722e06d7bd6654 Author: Antoine Lambert <anlambert@softwareheritage.org> Date: Tue May 3 17:42:16 2022 +0200 requirements.txt: Remove sphinx version pin Encountered issues have been fixed so we can remove the pinning of sphinx.
Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/168/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/168/console
Build has FAILED
Patch application report for D7731 (id=27957)
Rebasing onto 551fd26636...
Current branch diff-target is up to date.
Changes applied before test
commit 32fa29a5238845c9a696d6e80d722e06d7bd6654 Author: Antoine Lambert <anlambert@softwareheritage.org> Date: Tue May 3 17:42:16 2022 +0200 requirements.txt: Remove sphinx version pin Encountered issues have been fixed so we can remove the pinning of sphinx.
Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/170/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/170/console
Build has FAILED
Patch application report for D7731 (id=27990)
Rebasing onto 722a948a6f...
Current branch diff-target is up to date.
Changes applied before test
commit 7e1ea647f5ba7867aab1a212789b6c847f29ae57 Author: Antoine Lambert <anlambert@softwareheritage.org> Date: Tue May 3 17:42:16 2022 +0200 requirements.txt: Remove sphinx version pin Encountered issues have been fixed so we can remove the pinning of sphinx.
Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/179/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/179/console
Build is green
Patch application report for D7731 (id=28093)
Rebasing onto e3b9203165...
Current branch diff-target is up to date.
Changes applied before test
commit 364b70355d02d2a428830a14e955d0ae6b4d0812 Author: Antoine Lambert <anlambert@softwareheritage.org> Date: Tue May 3 17:42:16 2022 +0200 requirements.txt: Remove sphinx version pin Encountered issues have been fixed so we can remove the pinning of sphinx.
See https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/184/ for more details.
did they fix https://github.com/sphinx-doc/sphinx/issues/10124 ?
No, I simply fixed the two types ambiguity in our codebase that were leading to more than one target found for cross-reference warnings (D7762, D7763).
and != 4.4.0 should remain, because it is still incompatible with our documentation
Alright.
and != 4.4.0 should remain, because it is still incompatible with our documentation
In fact it is, I just rebuilt the whole doc from scratch using sphinx 4.4.0 and the build succeeded.
So we can land the diff as it is.
Build is green
Patch application report for D7731 (id=28175)
Rebasing onto a82aaf7215...
Current branch diff-target is up to date.
Changes applied before test
commit 1be5975ec6bd591fbb4438bb838fed3f7da0eb4b Author: Antoine Lambert <anlambert@softwareheritage.org> Date: Tue May 10 13:15:34 2022 +0200 gitignore: Add apidoc folder commit 29c11a7a0c7368a0892ec5ec62c9b8dd18d2a5c0 Author: Antoine Lambert <anlambert@softwareheritage.org> Date: Tue May 3 17:42:16 2022 +0200 requirements.txt: Remove sphinx version pin Encountered issues have been fixed so we can remove the pinning of sphinx.
See https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/187/ for more details.