Page MenuHomeSoftware Heritage
Differential D7719

Dedup `format_git_object_from_headers`
ClosedPublic
Actions

Authored by Ericson2314 on May 1 2022, 5:37 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDMODfe4ebb2f51aa: Dedup `format_git_object_from_headers`
Summary

We can use format_git_object_from_parts inside it.

Diff Detail

Repository
rDMOD Data model
Branch
dedup-git-objects
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 28982
Build 45306: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 45305: arc lint + arc unit

Event Timeline

Ericson2314 created this revision.May 1 2022, 5:37 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMay 1 2022, 5:37 PM
Ericson2314 added a comment.May 1 2022, 5:38 PM

Just a little thing I noticed :). Doesn't block any SWH <-> IPFS work.

swh-public-ci added a comment.May 1 2022, 5:40 PM

Build is green

Patch application report for D7719 (id=27917)

Rebasing onto 08c69e6379...

Current branch diff-target is up to date.
Changes applied before test
commit fe4ebb2f51aa83f7c3f68e38f4890aee2bc6862f
Author: John Ericson <John.Ericson@Obsidian.Systems>
Date:   Sun May 1 11:36:32 2022 -0400

    Dedup `format_git_object_from_headers`
    
    We can use `format_git_object_from_parts` inside it.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/482/ for more details.

Harbormaster completed remote builds in B28982: Diff 27917.May 1 2022, 5:40 PM
Ericson2314 requested review of this revision.May 1 2022, 5:40 PM
vlorentz accepted this revision.May 1 2022, 5:48 PM
This revision is now accepted and ready to land.May 1 2022, 5:48 PM
Closed by commit rDMODfe4ebb2f51aa: Dedup `format_git_object_from_headers` (authored by Ericson2314). · Explain WhyMay 1 2022, 6:28 PM
This revision was automatically updated to reflect the committed changes.
Ericson2314 added a commit: rDMODfe4ebb2f51aa: Dedup `format_git_object_from_headers`.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
model/
5 lines89%
Loading...

Diff 27917

View Options

swh/model/git_objects.py

Loading...
About · Developer information · Legal