Differential D7704

tasks: Simplify implementation and add tests for listed origins
ClosedPublic
Actions

Authored by anlambert on Apr 27 2022, 5:11 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Maniphest Tasks

T4187: Pass forge type to loaders

Commits

rDLDBASE39ad939b6ea2: tasks: Simplify implementation and add tests for listed origins

Summary

Recent changes in swh-scheduler add new parameters to the celery tasks
produced from swh.scheduler.model.ListedOrigin instances.

So ensure to handle any new parameters by not hardcoding the expected
ones in task signatures.

Remove unsafe use of unnamed task parameters.

Add new tests checking task parameters produced from ListedOrigin
instances do no raise error when attempting to create a package loader.

Related to T4187

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

simplify-tasks

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 28909
Build 45183: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 45182: arc lint + arc unit

Event Timeline

anlambert created this revision.Apr 27 2022, 5:11 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 27 2022, 5:11 PM

Build has FAILED

Patch application report for D7704 (id=27847)

Rebasing onto abc5f0889f...

First, rewinding head to replay your work on top of it...
Applying: tasks: Simplify implementation and add tests for listed origins

Changes applied before test

commit 18063e57e12a2c49c4e66a95e66e7c1090e5316f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Apr 27 17:11:14 2022 +0200

    tasks: Simplify implementation and add tests for listed origins
    
    Recent changes in swh-scheduler add new parameters to the celery tasks
    produced from swh.scheduler.model.ListedOrigin instances.
    
    So ensure to handle any new parameters by not hardcoding the expected
    ones in task signatures.
    
    Remove unsafe use of unnamed task parameters.
    
    Add new tests checking task parameters produced from ListedOrigin
    instances do no raise error when attempting to create a package loader.
    
    Related to T4187

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/750/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/750/console

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 27 2022, 5:12 PM

Harbormaster failed remote builds in B28909: Diff 27847!

Build is green

Patch application report for D7704 (id=27847)

Rebasing onto abc5f0889f...

First, rewinding head to replay your work on top of it...
Applying: tasks: Simplify implementation and add tests for listed origins

Changes applied before test

commit a37d2b6cd11c07be034c12c1a77cd55c748fd1ef
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Apr 27 17:11:14 2022 +0200

    tasks: Simplify implementation and add tests for listed origins
    
    Recent changes in swh-scheduler add new parameters to the celery tasks
    produced from swh.scheduler.model.ListedOrigin instances.
    
    So ensure to handle any new parameters by not hardcoding the expected
    ones in task signatures.
    
    Remove unsafe use of unnamed task parameters.
    
    Add new tests checking task parameters produced from ListedOrigin
    instances do no raise error when attempting to create a package loader.
    
    Related to T4187

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/751/ for more details.

Harbormaster completed remote builds in B28909: Diff 27847.Apr 27 2022, 5:28 PM

anlambert requested review of this revision.Apr 27 2022, 5:28 PM

Rebase

Build is green

Patch application report for D7704 (id=27852)

Rebasing onto abc5f0889f...

Current branch diff-target is up to date.

Changes applied before test

commit 39ad939b6ea2ee900e4470e4787a28ae1f6b95db
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Apr 27 17:11:14 2022 +0200

    tasks: Simplify implementation and add tests for listed origins
    
    Recent changes in swh-scheduler add new parameters to the celery tasks
    produced from swh.scheduler.model.ListedOrigin instances.
    
    So ensure to handle any new parameters by not hardcoding the expected
    ones in task signatures.
    
    Remove unsafe use of unnamed task parameters.
    
    Add new tests checking task parameters produced from ListedOrigin
    instances do no raise error when attempting to create a package loader.
    
    Related to T4187

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/752/ for more details.

Harbormaster completed remote builds in B28913: Diff 27852.Apr 27 2022, 6:00 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 27 2022, 6:01 PM

Closed by commit rDLDBASE39ad939b6ea2: tasks: Simplify implementation and add tests for listed origins (authored by anlambert). · Explain Why

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDBASE39ad939b6ea2: tasks: Simplify implementation and add tests for listed origins.