Make user_agent a parameter of GitHubSession
ClosedPublic
Actions

Authored by vlorentz on Apr 25 2022, 3:55 PM.

Details

Reviewers

ardumont
olasd

Group Reviewers

Reviewers

Commits

rDLSd715aaf903bb: Make user_agent a parameter of GitHubSession

Summary

So it can be set when used by other packages

Addresses D7630#199322

Diff Detail

Repository

rDLS Listers

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 28726
Build 44890: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 44889: arc lint + arc unit

Event Timeline

vlorentz created this revision.Apr 25 2022, 3:55 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 25 2022, 3:55 PM

vlorentz mentioned this in D7630: github: Refactor rate-limiting out of the GitHubLister class.Apr 25 2022, 3:55 PM

Build is green

Patch application report for D7646 (id=27669)

Could not rebase; Attempt merge onto 2fa9f0abd2...

Updating 2fa9f0a..2bbb6c8
Fast-forward
 swh/lister/github/lister.py            | 169 ++------------------------------
 swh/lister/github/tests/test_lister.py |  15 +--
 swh/lister/github/utils.py             | 170 +++++++++++++++++++++++++++++++++
 3 files changed, 188 insertions(+), 166 deletions(-)
 create mode 100644 swh/lister/github/utils.py

Changes applied before test

commit 2bbb6c81022a316f7a2ce191440f2610d3ce1299
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Apr 25 15:53:41 2022 +0200

    Make user_agent a parameter of GitHubSession
    
    So it can be set when used by other packages

commit 2a993230e6547ad19ce90f11e09c1a187c6c60a3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Apr 25 15:44:39 2022 +0200

    Move GitHubSession from github/lister.py to github/utils.py
    
    So it can be reused by other packages without importing lister.py itself

commit f91caedbb2ed5eca2572b7b5ebe1413692496f60
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 21 20:34:50 2022 +0200

    github: Refactor rate-limiting out of the GitHubLister class
    
    This will allow the GitHub Metadata Fetcher to reuse the logic
    by importing the GitHubSession class.

commit d0924f39d04e7b7128c55a116280e2c6b6ec5a00
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 21 20:32:45 2022 +0200

    github: Remove dead code
    
    Authentication is handled directly in the session

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/498/ for more details.

Harbormaster completed remote builds in B28726: Diff 27669.Apr 25 2022, 3:58 PM

vlorentz requested review of this revision.Apr 25 2022, 3:58 PM

ardumont accepted this revision.Apr 25 2022, 4:22 PM

This revision is now accepted and ready to land.Apr 25 2022, 4:22 PM

Cool, thanks.

rebase

Build is green

Patch application report for D7646 (id=27700)

Could not rebase; Attempt merge onto 334c54091e...

Updating 334c540..d715aaf
Fast-forward
 swh/lister/github/lister.py            | 161 ++-----------------------------
 swh/lister/github/tests/test_lister.py |  15 +--
 swh/lister/github/utils.py             | 170 +++++++++++++++++++++++++++++++++
 3 files changed, 188 insertions(+), 158 deletions(-)
 create mode 100644 swh/lister/github/utils.py

Changes applied before test

commit d715aaf903bb517873ec9716e0cc397da1fc64cd
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Apr 25 15:53:41 2022 +0200

    Make user_agent a parameter of GitHubSession
    
    So it can be set when used by other packages

commit 2d04244cc950bfad254b7337449d2fe20e36f610
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Apr 25 15:44:39 2022 +0200

    Move GitHubSession from github/lister.py to github/utils.py
    
    So it can be reused by other packages without importing lister.py itself

commit 9ee4a99f152d9d6cbe5a6a09895ce9384660be46
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 21 20:34:50 2022 +0200

    github: Refactor rate-limiting out of the GitHubLister class
    
    This will allow the GitHub Metadata Fetcher to reuse the logic
    by importing the GitHubSession class.

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/504/ for more details.

Harbormaster completed remote builds in B28757: Diff 27700.Apr 26 2022, 11:12 AM

Closed by commit rDLSd715aaf903bb: Make user_agent a parameter of GitHubSession (authored by vlorentz). · Explain WhyApr 26 2022, 11:28 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLSd715aaf903bb: Make user_agent a parameter of GitHubSession.