Page MenuHomeSoftware Heritage
Differential D7633

Initialize base metadata fetcher + github
ClosedPublic
Actions

Authored by vlorentz on Apr 22 2022, 3:07 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T1740: fetch extrinsic origin metadata from GitHub
Commits
rDLDMDaa0af83a5e04: Initialize base metadata fetcher + github
Test Plan

Will fail, because this depends on D7630 and D7632 being released

Diff Detail

Repository
rDLDMD Extrinsic Metadata Loaders
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 22 2022, 3:07 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 22 2022, 3:07 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 22 2022, 3:07 PM
Harbormaster failed remote builds in B28693: Diff 27639!
vlorentz requested review of this revision.Apr 22 2022, 3:11 PM
vlorentz added a task: T1740: fetch extrinsic origin metadata from GitHub.Apr 22 2022, 3:52 PM
vlorentz updated this revision to Diff 27649.Apr 22 2022, 4:41 PM

fix inconsistent name

swh-public-ci added a comment.Apr 22 2022, 4:42 PM

Build has FAILED

Patch application report for D7633 (id=27649)

Rebasing onto bfc39f3580...

Current branch diff-target is up to date.
Changes applied before test
commit f7a18d19c9b16f7bb90042e4d49c2a3209c25485
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Apr 22 15:04:22 2022 +0200

    Initialize base metadata fetcher + github

Link to build: https://jenkins.softwareheritage.org/job/DLDMD/job/tests-on-diff/1/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDMD/job/tests-on-diff/1/console

Harbormaster failed remote builds in B28702: Diff 27649!Apr 22 2022, 4:42 PM
ardumont added a subscriber: ardumont.Apr 25 2022, 5:13 PM
ardumont added inline comments.
requirements-swh.txt
1

so i guess we'll have a requirement change here, something like?

swh/loader/metadata/base.py
103–104
108

We are mostly using the imperative form nowadays, aren't we?

vlorentz added inline comments.Apr 25 2022, 5:21 PM
requirements-swh.txt
1

currently, no.

And extras *add* features, they don't make it so *only* the mentioned feature is installed

swh/loader/metadata/base.py
103–104

wow

108

I don't know

ardumont added inline comments.Apr 25 2022, 5:22 PM
swh/loader/metadata/base.py
182

is the print useful as well?

swh/loader/metadata/tests/test_github.py
72–94

?

vlorentz added inline comments.Apr 25 2022, 5:24 PM
swh/loader/metadata/base.py
182

yes, it makes flake8 not complain about the unused var

ardumont accepted this revision.Apr 25 2022, 5:24 PM

lgtm, couple of remarks inline.

swh/loader/metadata/tests/test_github.py
49

you can drop it.

This revision is now accepted and ready to land.Apr 25 2022, 5:24 PM
ardumont added inline comments.Apr 25 2022, 5:25 PM
swh/loader/metadata/base.py
103–104

ikr ;)

vlorentz updated this revision to Diff 27678.Apr 25 2022, 5:42 PM

apply all comments

swh-public-ci added a comment.Apr 25 2022, 5:43 PM

Build has FAILED

Patch application report for D7633 (id=27678)

Rebasing onto bfc39f3580...

Current branch diff-target is up to date.
Changes applied before test
commit c742edd752a68eabc86a4c6c54ee1eed9cd5f8e3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Apr 22 15:04:22 2022 +0200

    Initialize base metadata fetcher + github

Link to build: https://jenkins.softwareheritage.org/job/DLDMD/job/tests-on-diff/2/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDMD/job/tests-on-diff/2/console

vlorentz marked 4 inline comments as done.Apr 25 2022, 5:43 PM
Harbormaster failed remote builds in B28737: Diff 27678!Apr 25 2022, 5:43 PM
ardumont added inline comments.Apr 25 2022, 5:56 PM
requirements-swh.txt
1

fine

ardumont added inline comments.Apr 25 2022, 5:58 PM
swh/loader/metadata/tests/test_github.py
49

ping?

(that's not for type this time, isn't it?)

vlorentz added inline comments.Apr 26 2022, 9:24 AM
swh/loader/metadata/tests/test_github.py
49

it's still for flake8

swh-public-ci added a comment.Apr 26 2022, 11:53 AM

Build has FAILED

Patch application report for D7633 (id=27678)

Rebasing onto bfc39f3580...

Current branch diff-target is up to date.
Changes applied before test
commit c742edd752a68eabc86a4c6c54ee1eed9cd5f8e3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Apr 22 15:04:22 2022 +0200

    Initialize base metadata fetcher + github

Link to build: https://jenkins.softwareheritage.org/job/DLDMD/job/tests-on-diff/3/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDMD/job/tests-on-diff/3/console

vlorentz updated this revision to Diff 27711.Apr 26 2022, 12:16 PM

fix mypy

swh-public-ci added a comment.Apr 26 2022, 12:18 PM

Build has FAILED

Patch application report for D7633 (id=27711)

Rebasing onto bfc39f3580...

Current branch diff-target is up to date.
Changes applied before test
commit 46e9be8a9f9ba70a24f982c5e4448f7cb4dde6f7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Apr 22 15:04:22 2022 +0200

    Initialize base metadata fetcher + github

Link to build: https://jenkins.softwareheritage.org/job/DLDMD/job/tests-on-diff/4/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDMD/job/tests-on-diff/4/console

Harbormaster failed remote builds in B28768: Diff 27711!Apr 26 2022, 12:18 PM
vlorentz updated this revision to Diff 27713.Apr 26 2022, 12:26 PM

fix tests again

swh-public-ci added a comment.Apr 26 2022, 12:29 PM

Build is green

Patch application report for D7633 (id=27713)

Rebasing onto bfc39f3580...

Current branch diff-target is up to date.
Changes applied before test
commit aa0af83a5e04dfc938eeeefca5f92756fac7dca9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Apr 22 15:04:22 2022 +0200

    Initialize base metadata fetcher + github

See https://jenkins.softwareheritage.org/job/DLDMD/job/tests-on-diff/5/ for more details.

Harbormaster completed remote builds in B28770: Diff 27713.Apr 26 2022, 12:29 PM
Closed by commit rDLDMDaa0af83a5e04: Initialize base metadata fetcher + github (authored by vlorentz). · Explain WhyApr 26 2022, 12:30 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDLDMDaa0af83a5e04: Initialize base metadata fetcher + github.

Revision Contents
Changeset List

PathSize
conftest.py/
swh/
foo/
bar.py
7 lines
docs/
7 lines
2 lines
3 lines
4 lines
6 lines
17 lines
swh/
foo/
tests/
loader/
3 lines
metadata/
15 lines
184 lines
69 lines
tests/
data/
https_api.github.com/
103 lines
108 lines
95 lines
loader/
metadata/
foo/
metadata/
tests/
foo/
7 lines

Diff 27718

View Options

conftest.py

Loading...
View Options

docs/README.rst

Loading...
View Options

docs/index.rst

Loading...
View Options

mypy.ini

Loading...
View Options

requirements-swh.txt

Loading...
View Options

requirements-test.txt

Loading...
View Options

setup.py

Loading...
View Options

swh/foo/__init__.py

Loading...
View Options

swh/foo/bar.py

Loading...
View Options

swh/foo/cli.py

Loading...
View Options

swh/foo/py.typed

Loading...
View Options

swh/foo/tests/__init__.py

Loading...
View Options

swh/foo/tests/test_nothing.py

Loading...
View Options

swh/loader/__init__.py

Loading...
View Options

swh/loader/metadata/__init__.py

Loading...
View Options

swh/loader/metadata/bar.py

Loading...
View Options

swh/loader/metadata/base.py

Loading...
View Options

swh/loader/metadata/github.py

Loading...
View Options

swh/loader/metadata/py.typed

Loading...
View Options

swh/loader/metadata/tests/__init__.py

Loading...
View Options

swh/loader/metadata/tests/data/https_api.github.com/repos_octocat_Hello-World

Loading...
View Options

swh/loader/metadata/tests/test_base.py

Loading...
View Options

swh/loader/metadata/tests/test_github.py

Loading...
View Options

tox.ini

Loading...
About · Developer information · Legal