BaseLoader: Add 'origin_url' argument and remove 'prepare_origin_visit' method
ClosedPublic
Actions

Authored by vlorentz on Apr 21 2022, 9:50 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T4187: Pass forge type to loaders

Commits

rDLDBASE59814745be54: BaseLoader: Add 'origin_url' argument and remove 'prepare_origin_visit' method

Summary

Loaders only use prepare_origin_visit to set the origin and visit date,
so it is simpler to do it in BaseLoader.__init__.

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 21 2022, 9:50 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 21 2022, 9:50 AM

Build is green

Patch application report for D7610 (id=27566)

Rebasing onto cc227cab28...

Current branch diff-target is up to date.

Changes applied before test

commit 59814745be545c715db6b6e1794a92e5f29c50bc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 21 09:48:36 2022 +0200

    BaseLoader: Add 'origin_url' argument and remove 'prepare_origin_visit' method
    
    Loaders only use prepare_origin_visit to set the origin and visit date,
    so it is simpler to do it in `BaseLoader.__init__`.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/722/ for more details.

Harbormaster completed remote builds in B28595: Diff 27566.Apr 21 2022, 9:53 AM

vlorentz requested review of this revision.Apr 21 2022, 9:53 AM

vlorentz added a child revision: D7611: cvs: Update for swh.loader.core 3.0.0 and remove initialization boilerplate.Apr 21 2022, 9:55 AM

vlorentz added a child revision: D7612: git: Update for swh.loader.core 3.0.0 and remove initialization boilerplate.Apr 21 2022, 10:01 AM

vlorentz added a child revision: D7613: hg: Update for swh.loader.core 3.0.0 and remove initialization boilerplate.Apr 21 2022, 10:04 AM

vlorentz added a child revision: D7614: bzr: Update for swh.loader.core 3.0.0 and remove initialization boilerplate.Apr 21 2022, 10:06 AM

vlorentz added a child revision: D7615: svn: Update for swh.loader.core 3.0.0 and remove initialization boilerplate.Apr 21 2022, 10:11 AM