Page MenuHomeSoftware Heritage

maven: Continue listing if unable to retrieve pom information
ClosedPublic

Authored by ardumont on Apr 13 2022, 6:00 PM.

Details

Summary

This aligns the behavior with other listers (e.g. sourceforge, ...) to continue listing
if some information is not retrievable at all.

Related to T3874

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7572 (id=27426)

Could not rebase; Attempt merge onto 0e0901acdc...

Updating 0e0901a..7c8428d
Fast-forward
 swh/lister/maven/lister.py            | 15 +++++++++++----
 swh/lister/maven/tests/test_lister.py | 34 ++++++++++++++++++----------------
 2 files changed, 29 insertions(+), 20 deletions(-)
Changes applied before test
commit 7c8428d01c7346b6d2b1aee84ee1b565f61c07ed
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Apr 13 17:45:34 2022 +0200

    maven: Continue listing if unable to retrieve pom information
    
    This aligns the behavior with other listers (e.g. sourceforge, ...) to continue listing
    if some information is not retrievable at all.
    
    Related to T3874

commit e4b27a1e9878868781e97c7ee9d2af490e6cdf6b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Apr 13 17:40:17 2022 +0200

    maven: log error message when not able to retrieve the index to read
    
    Without this, the lister legitimately cannot list anything.

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/486/ for more details.

This revision is now accepted and ready to land.Apr 13 2022, 6:08 PM