Differential D7524

Fix crash when reading metadata of deposits with no metadata
ClosedPublic
Actions

Authored by vlorentz on Apr 7 2022, 2:50 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDDEPe68442ec71d7: Fix crash when reading metadata of deposits with no metadata

Summary

Resolves SWH-DEPOSIT-2P https://sentry.softwareheritage.org/share/issue/b8509b67972f425a8f5c06805f8cf2fe/

Diff Detail

Repository

rDDEP Push deposit

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 28224
Build 44191: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 44190: arc lint + arc unit

Event Timeline

vlorentz created this revision.Apr 7 2022, 2:50 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 7 2022, 2:50 PM

Build is green

Patch application report for D7524 (id=27293)

Rebasing onto 56da78d0bf...

Current branch diff-target is up to date.

Changes applied before test

commit e68442ec71d794d1b7e2affb93f0b64eea645a20
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 7 14:49:14 2022 +0200

    Fix crash when reading metadata of deposits with no metadata
    
    Resolves SWH-DEPOSIT-2P <https://sentry.softwareheritage.org/share/issue/b8509b67972f425a8f5c06805f8cf2fe/>

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/832/ for more details.

Harbormaster completed remote builds in B28224: Diff 27293.Apr 7 2022, 2:57 PM

vlorentz requested review of this revision.Apr 7 2022, 2:57 PM

ardumont accepted this revision.Apr 7 2022, 2:59 PM

This revision is now accepted and ready to land.Apr 7 2022, 2:59 PM

Closed by commit rDDEPe68442ec71d7: Fix crash when reading metadata of deposits with no metadata (authored by vlorentz). · Explain WhyApr 7 2022, 3:19 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDDEPe68442ec71d7: Fix crash when reading metadata of deposits with no metadata.

ardumont mentioned this in T4125: Deploy deposit v1.0.Apr 8 2022, 10:55 AM