Page MenuHomeSoftware Heritage
Differential D7449

swh.web.inbound_email: Add missing __init__.py file
ClosedPublic
Actions

Authored by ardumont on Mar 29 2022, 9:55 AM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDWAPPSf8e4ad3a51ab: swh.web.inbound_email: Add missing __init__.py file
Summary

My hypothesis is that those missing files are making the swh-docs build fail.
That's the only difference i see between those swh.web folders and the rest.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mar 29 2022, 9:55 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 29 2022, 9:55 AM
ardumont mentioned this in D7445: roadmap 2022 documentation.Mar 29 2022, 9:56 AM
swh-public-ci added a comment.Mar 29 2022, 9:57 AM

Build has FAILED

Patch application report for D7449 (id=26959)

Could not rebase; Attempt merge onto 4bc8aaf1d9...

Updating 4bc8aaf1..cff7880d
Fast-forward
 swh/web/add_forge_now/models.py                       | 6 ++++++
 swh/web/inbound_email/management/__init__.py          | 0
 swh/web/inbound_email/management/commands/__init__.py | 0
 3 files changed, 6 insertions(+)
 create mode 100644 swh/web/inbound_email/management/__init__.py
 create mode 100644 swh/web/inbound_email/management/commands/__init__.py
Changes applied before test
commit cff7880d03d1a499ed5a2ac7630987ac4818cbe4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:50:12 2022 +0200

    swh.web.inbound_email: Add missing __init__.py file
    
    My hypothesis is that those missing files are making the swh-docs build fail.
    That's the only difference i see between those swh.web folders and the rest.

commit 2531af642f005897b208255221a052ac41795c3a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:25:24 2022 +0200

    Install app_label on add_forge_now model classes
    
    This should alleviate problems in documentation build.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1607/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1607/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 29 2022, 9:57 AM
Harbormaster failed remote builds in B27875: Diff 26959!
ardumont updated this revision to Diff 26960.Mar 29 2022, 10:23 AM

Rebase

swh-public-ci added a comment.Mar 29 2022, 10:29 AM

Build has FAILED

Patch application report for D7449 (id=26959)

Could not rebase; Attempt merge onto 4bc8aaf1d9...

Updating 4bc8aaf1..cff7880d
Fast-forward
 swh/web/add_forge_now/models.py                       | 6 ++++++
 swh/web/inbound_email/management/__init__.py          | 0
 swh/web/inbound_email/management/commands/__init__.py | 0
 3 files changed, 6 insertions(+)
 create mode 100644 swh/web/inbound_email/management/__init__.py
 create mode 100644 swh/web/inbound_email/management/commands/__init__.py
Changes applied before test
commit cff7880d03d1a499ed5a2ac7630987ac4818cbe4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:50:12 2022 +0200

    swh.web.inbound_email: Add missing __init__.py file
    
    My hypothesis is that those missing files are making the swh-docs build fail.
    That's the only difference i see between those swh.web folders and the rest.

commit 2531af642f005897b208255221a052ac41795c3a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:25:24 2022 +0200

    Install app_label on add_forge_now model classes
    
    This should alleviate problems in documentation build.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1608/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1608/console

swh-public-ci added a comment.Mar 29 2022, 10:45 AM

Build was aborted

Patch application report for D7449 (id=26960)

Rebasing onto 4bc8aaf1d9...

Current branch diff-target is up to date.
Changes applied before test
commit 0c1e63d70261d917be5f4c3400772c6864e6cb56
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:50:12 2022 +0200

    swh.web.inbound_email: Add missing __init__.py file
    
    My hypothesis is that those missing files are making the swh-docs build fail.
    That's the only difference i see between those swh.web folders and the rest.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1609/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1609/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 29 2022, 10:45 AM
Harbormaster failed remote builds in B27876: Diff 26960!
ardumont added a comment.Mar 29 2022, 10:50 AM

Build was aborted

roh come on!

ardumont added a comment.Mar 29 2022, 11:23 AM

Build was aborted

roh come on!

*sigh*
opened D7450 for this.

swh-public-ci added a comment.Mar 29 2022, 12:00 PM

Build is green

Patch application report for D7449 (id=26960)

Rebasing onto 4bc8aaf1d9...

Current branch diff-target is up to date.
Changes applied before test
commit 0c1e63d70261d917be5f4c3400772c6864e6cb56
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:50:12 2022 +0200

    swh.web.inbound_email: Add missing __init__.py file
    
    My hypothesis is that those missing files are making the swh-docs build fail.
    That's the only difference i see between those swh.web folders and the rest.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1615/ for more details.

Harbormaster completed remote builds in B27876: Diff 26960.Mar 29 2022, 12:00 PM
ardumont requested review of this revision.Mar 29 2022, 12:00 PM
ardumont added a subscriber: olasd.Mar 29 2022, 12:10 PM

@olasd fwiw, i'm also dubious about that one (for benoit's diff as well) ¯\_(ツ)_/¯

anlambert accepted this revision.Mar 29 2022, 3:15 PM
This revision is now accepted and ready to land.Mar 29 2022, 3:15 PM
ardumont updated this revision to Diff 26998.Mar 29 2022, 3:17 PM

Rebase

This revision was landed with ongoing or failed builds.Mar 29 2022, 3:18 PM
Closed by commit rDWAPPSf8e4ad3a51ab: swh.web.inbound_email: Add missing __init__.py file (authored by ardumont). · Explain Why
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDWAPPSf8e4ad3a51ab: swh.web.inbound_email: Add missing __init__.py file.
swh-public-ci added a comment.Mar 29 2022, 3:40 PM

Build is green

Patch application report for D7449 (id=26998)

Rebasing onto f8e4ad3a51...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-1623-D7449.
Changes applied before test



See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1623/ for more details.
Harbormaster completed remote builds in B27914: Diff 26998.Mar 29 2022, 3:40 PM
Revision Contents
Changeset List
PathSize
swh/
web/
inbound_email/
management/
commands/
Diff 27001
View Options
swh/web/inbound_email/management/__init__.py
Loading...
View Options
swh/web/inbound_email/management/commands/__init__.py
Loading...
About · Developer information · Legal