Differential D7411

Style improvements for forge request dashboard
ClosedPublic
Actions

Authored by jayeshv on Mar 22 2022, 6:01 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPS2e4a9bf6f8de: Style improvements for forge request dashboard

Summary

Moved forge request details to a separate column
Minor style changes to request history items
Added separate CSS for add-forge bundle

Diff Detail

Repository

rDWAPPS Web applications

Branch

request-dashboard-style

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 27726
Build 43398: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 43397: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	20,945 ms	Jenkins > should load add forge request details::Tests / Cypress tests / Run cypress tests / Test add forge now request dashboard load should load add forge request details AssertionError: Timed out retrying after 20000ms: Expected to find element: `#requestType`, but never found it. at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/integration/add-forge-now-request-dashboard.spec.js:118:28)
	20,865 ms	Jenkins > should not show any error message::Tests / Cypress tests / Run cypress tests / Test add forge now request dashboard load should not show any error message AssertionError: Timed out retrying after 20000ms: Expected to find element: `#fetchError`, but never found it. at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/integration/add-forge-now-request-dashboard.spec.js:123:27)
	21,503 ms	Jenkins > should show error message for an api error::Tests / Cypress tests / Run cypress tests / Test add forge now request dashboard load should show error message for an api error AssertionError: Timed out retrying after 20000ms: Expected to find element: `#fetchError`, but never found it. at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/integration/add-forge-now-request-dashboard.spec.js:130:27)
	282 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.add_forge_now.tests.test_migration::Tests / Python tests / test_add_forge_now_allow_no_comment
	796 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.add_forge_now.tests.test_migration::Tests / Python tests / test_add_forge_now_initial_migration
		View Full Test Results (3 Failed · 885 Passed · 5 Skipped)

Event Timeline

jayeshv created this revision.Mar 22 2022, 6:01 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 22 2022, 6:01 PM

jayeshv edited the summary of this revision. (Show Details)Mar 22 2022, 6:02 PM

jayeshv edited the summary of this revision. (Show Details)

jayeshv edited the summary of this revision. (Show Details)Mar 22 2022, 6:05 PM

Build was aborted

Patch application report for D7411 (id=26805)

Rebasing onto 74a5fc48c8...

Current branch diff-target is up to date.

Changes applied before test

commit 143c130c7eaeb440838aad915431b10bb5b54927
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Mar 22 17:58:49 2022 +0100

    Style improvements for forge request dashboard
    
    Moved forge request details to a separate column
    Minor style changes to request history items
    Added separate CSS for add-forge bundle

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1543/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1543/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 22 2022, 6:24 PM

Harbormaster failed remote builds in B27726: Diff 26805!

Fixed the failing tests

jayeshv edited the summary of this revision. (Show Details)Mar 23 2022, 8:34 AM

Build is green

Patch application report for D7411 (id=26807)

Rebasing onto 74a5fc48c8...

Current branch diff-target is up to date.

Changes applied before test

commit 23f941cf8488fc243465856af93d827092fffa12
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Mar 23 08:28:56 2022 +0100

    Style improvements for forge request dashboard
    
    Moved forge request details to a separate column
    Minor style changes to request history items
    Added separate CSS for add-forge bundle

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1544/ for more details.

Harbormaster completed remote builds in B27728: Diff 26807.Mar 23 2022, 8:48 AM

jayeshv requested review of this revision.Mar 23 2022, 8:48 AM

Looks great, thanks.

vlorentz accepted this revision.Mar 23 2022, 10:08 AM

This revision is now accepted and ready to land.Mar 23 2022, 10:08 AM

Minor change; removed capital letters

This revision was landed with ongoing or failed builds.Mar 23 2022, 10:33 AM

Closed by commit rDWAPPS2e4a9bf6f8de: Style improvements for forge request dashboard (authored by jayeshv). · Explain Why

This revision was automatically updated to reflect the committed changes.

jayeshv added a commit: rDWAPPS2e4a9bf6f8de: Style improvements for forge request dashboard.

Build is green

Patch application report for D7411 (id=26811)

Rebasing onto 74a5fc48c8...

Current branch diff-target is up to date.

Changes applied before test

commit 2e4a9bf6f8de423e8b9baf5ae3c45014a7edc043
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Mar 23 10:29:07 2022 +0100

    Style improvements for forge request dashboard
    
    Moved forge request details to a separate column
    Minor style changes to request history items
    Added separate CSS for add-forge bundle

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1545/ for more details.

Harbormaster completed remote builds in B27731: Diff 26811.Mar 23 2022, 10:50 AM