Differential D7372

Exclude name and email attributes from People comparison
ClosedPublic
Actions

Authored by douardda on Mar 17 2022, 6:17 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDMODbc3831fddcd3: Exclude name and email attributes from People comparison

Summary

these fields are computed attributes and may be removed from the backend
storage. Helps writing tests.

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Mar 17 2022, 6:17 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 17 2022, 6:17 PM

Build is green

Patch application report for D7372 (id=26653)

Rebasing onto dc5485e4a1...

Current branch diff-target is up to date.

Changes applied before test

commit e49fb0b3024b484f6f23accdcd1b608a4ecc370d
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Mar 17 14:19:50 2022 +0100

    Exclude name and email attributes from People comparision
    
    these fields are computed attributes and may be removed from the backend
    storage. Helps writing tests.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/462/ for more details.

Harbormaster completed remote builds in B27536: Diff 26653.Mar 17 2022, 6:20 PM

douardda requested review of this revision.Mar 17 2022, 6:20 PM

Please, fix the typo in commit and diff description ("comparision").

Otherwise, lgtm.

typo

Build is green

Patch application report for D7372 (id=26664)

Rebasing onto dc5485e4a1...

Current branch diff-target is up to date.

Changes applied before test

commit bc3831fddcd309789a3f5e81eba37d4f28219201
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Mar 17 14:19:50 2022 +0100

    Exclude name and email attributes from People comparison
    
    these fields are computed attributes and may be removed from the backend
    storage. Helps writing tests.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/463/ for more details.

Harbormaster completed remote builds in B27547: Diff 26664.Mar 18 2022, 10:45 AM

ardumont accepted this revision.Mar 18 2022, 10:58 AM

ardumont retitled this revision from Exclude name and email attributes from People comparision to Exclude name and email attributes from People comparison.

This revision is now accepted and ready to land.Mar 18 2022, 10:58 AM

Closed by commit rDMODbc3831fddcd3: Exclude name and email attributes from People comparison (authored by douardda). · Explain WhyMar 18 2022, 11:24 AM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDMODbc3831fddcd3: Exclude name and email attributes from People comparison.