Page MenuHomeSoftware Heritage

Save Code Now: Rewrite github.io URLs
ClosedPublic

Authored by vlorentz on Mar 16 2022, 4:07 PM.

Details

Summary

We get a couple of these every week.

Resolves T3969.

It was actually easier to rewrite URLs than to reject them outright,
and it's probably better for users anyway.

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27497
Build 43028: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 43027: arc lint + arc unit

Event Timeline

and it's probably better for users anyway.

well, that way they will never learn their mistake...

Build is green

Patch application report for D7362 (id=26615)

Rebasing onto 9f2e1cb90c...

Current branch diff-target is up to date.
Changes applied before test
commit db139b07df29e484fd0eb8288455e5f43bed5979
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Mar 16 16:06:45 2022 +0100

    Save Code Now: Rewrite github.io URLs
    
    We get a couple of these every week.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1473/ for more details.

wait, does that rewrite the inputed url as well (so the users sees that the canonical url was used instead of their wrong input)?

if so, i'm fine with it.

anlambert added a subscriber: anlambert.

Cool stuff, thanks !

This revision is now accepted and ready to land.Mar 16 2022, 5:54 PM
This revision was landed with ongoing or failed builds.Mar 17 2022, 1:26 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D7362 (id=26634)

Rebasing onto 39bab96e9f...

Current branch diff-target is up to date.
Changes applied before test
commit 7bfbda85ff6d2b835d4c5eca28f61b9ae12dbf63
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Mar 16 16:06:45 2022 +0100

    Save Code Now: Rewrite github.io URLs
    
    We get a couple of these every week.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1485/ for more details.