Do not do call swh_db_upgrade if not needed in `swh db upgrade`
ClosedPublic
Actions

Authored by douardda on Mar 9 2022, 5:17 PM.

Details

Reviewers

Group Reviewers

Commits

rDCOREf40adde2a91d: Fix a possible UnboundLocalError in swh_db_upgrade
rDCORE6017252a078a: Do not do call swh_db_upgrade if not needed in `swh db upgrade`

Summary

also fix a possible UnboundLocalError in swh_db_upgrade
when no migration script is to be executed.

Diff Detail

Repository

rDCORE Foundations and core functionalities

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 27376
Build 42833: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 42832: arc lint + arc unit

Event Timeline

douardda created this revision.Mar 9 2022, 5:17 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 9 2022, 5:17 PM

Build is green

Patch application report for D7324 (id=26491)

Rebasing onto ae654de04e...

Current branch diff-target is up to date.

Changes applied before test

commit 7d9a946c1766c49b416e46d8f775631f8e75be37
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Mar 9 17:14:40 2022 +0100

    Fix a possible UnboundLocalError in swh_db_upgrade
    
    when no migration script is to be executed.

commit 6017252a078aa9d7d56a1a0c0ca9d5e674d01833
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Mar 9 16:08:53 2022 +0100

    Do not do call swh_db_upgrade if not needed in `swh db upgrade`

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/374/ for more details.

Harbormaster completed remote builds in B27376: Diff 26491.Mar 9 2022, 5:18 PM

douardda requested review of this revision.Mar 9 2022, 5:18 PM

lgtm

swh/core/db/db_utils.py
146–147

This revision is now accepted and ready to land.Mar 9 2022, 5:20 PM

fix suggested by ardumont

douardda marked an inline comment as done.Mar 9 2022, 5:42 PM

Build is green

Patch application report for D7324 (id=26492)

Rebasing onto ae654de04e...

Current branch diff-target is up to date.

Changes applied before test

commit f40adde2a91dbc7d63a7f1b878ff50e41ca442cb
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Mar 9 17:14:40 2022 +0100

    Fix a possible UnboundLocalError in swh_db_upgrade
    
    when no migration script is to be executed.

commit 6017252a078aa9d7d56a1a0c0ca9d5e674d01833
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Mar 9 16:08:53 2022 +0100

    Do not do call swh_db_upgrade if not needed in `swh db upgrade`

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/375/ for more details.

Harbormaster completed remote builds in B27377: Diff 26492.Mar 9 2022, 5:43 PM

Closed by commit rDCORE6017252a078a: Do not do call swh_db_upgrade if not needed in `swh db upgrade` (authored by douardda). · Explain WhyMar 9 2022, 5:44 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDCORE6017252a078a: Do not do call swh_db_upgrade if not needed in `swh db upgrade`.

douardda added a commit: rDCOREf40adde2a91d: Fix a possible UnboundLocalError in swh_db_upgrade.