I want to make swh-objstorage inherit from RPCClient, but its get() and get_stream()
methods would class with RPCClient's.
Details
Details
- Reviewers
olasd - Group Reviewers
Reviewers - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- rDCOREa2af8c667e32: RPCClient: Make methods {get,post}{,_stream} protected
Diff Detail
Diff Detail
- Repository
- rDCORE Foundations and core functionalities
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 27198 Build 42543: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 42542: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D7266 (id=26325)
Rebasing onto 9c9475f769...
Current branch diff-target is up to date.
Changes applied before test
commit a2af8c667e32e0523ae371506abc5aa0d11a85f8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Mar 1 15:04:44 2022 +0100
RPCClient: Make methods {get,post}{,_stream} protected
I want to make swh-objstorage inherit from RPCClient, but its get() and get_stream()
methods would class with RPCClient's.See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/362/ for more details.
Comment Actions
Thanks, that's been an itch previously.
I guess some other modules will need a followup diff, although most users of these methods are probably autogenerated.
| swh/core/api/__init__.py | ||
|---|---|---|
| 301 | Oh, that's never explicitly disposing of the response object, I wonder how/when the connections get properly returned to the pool (I guess the GC does it). | |