Page MenuHomeSoftware Heritage

Deduplicate parsing of add_to_origin/create_to_origin + add error logging in the client
ClosedPublic

Authored by vlorentz on Feb 22 2022, 3:43 PM.

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7222 (id=26180)

Rebasing onto 55ae87b13c...

Current branch diff-target is up to date.
Changes applied before test
commit c6a463e8700bd0694bf0ed1c37c9da38e1cf1bcf
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Feb 22 15:42:32 2022 +0100

    Deduplicate parsing of add_to_origin/create_to_origin + add error logging in the client

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/729/ for more details.

ardumont added a subscriber: ardumont.

one remark inline.

swh/deposit/cli/client.py
290

both... or sounds strange, both... and sounds better to me.

This revision is now accepted and ready to land.Feb 22 2022, 3:53 PM

rebase + typo

swh/deposit/cli/client.py
290

ah yes of course. that's because I copy-pasted from the other warning

This revision was landed with ongoing or failed builds.Feb 23 2022, 10:49 AM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D7222 (id=26193)

Rebasing onto cc3705a3d3...

Current branch diff-target is up to date.
Changes applied before test
commit 94f9aa2228d85733dd7e370ea7fe780b69b647cd
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Feb 22 15:42:32 2022 +0100

    Deduplicate parsing of add_to_origin/create_to_origin + add error logging in the client

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/735/ for more details.