deposit: Add utils to parse metadata provenance from atom entry file
ClosedPublic
Actions

Authored by ardumont on Feb 18 2022, 2:38 PM.

Details

Reviewers

moranegg
vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T3677: Separate origin-source-code and provenance-metadata in the deposit

Commits

rDDEP40adc8c23b98: deposit: Add utils to parse metadata provenance from atom entry file

Summary

It's not plugged anywhere just yet.

Related to T3677

Test Plan

tox

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Feb 18 2022, 2:38 PM

Build has FAILED

Patch application report for D7200 (id=26110)

Rebasing onto c30dc3da46...

Current branch diff-target is up to date.

Changes applied before test

commit 8def64d06183a0a42b4102e9e262866d9d4789f0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Feb 18 14:35:49 2022 +0100

    deposit: Add utils to parse metadata provenance from atom entry file
    
    Related to T3677

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/703/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/703/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 18 2022, 2:41 PM

Harbormaster failed remote builds in B26983: Diff 26110!

Fix docs which failed the build

Build is green

Patch application report for D7200 (id=26111)

Rebasing onto c30dc3da46...

Current branch diff-target is up to date.

Changes applied before test

commit 2857213c51cc11240b090b3a85b41efa4acc6a66
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Feb 18 14:35:49 2022 +0100

    deposit: Add utils to parse metadata provenance from atom entry file
    
    Related to T3677

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/704/ for more details.

Harbormaster completed remote builds in B26984: Diff 26111.Feb 18 2022, 2:58 PM

ardumont requested review of this revision.Feb 18 2022, 2:58 PM

ardumont added inline comments.Feb 18 2022, 3:15 PM

swh/deposit/utils.py
180	"liar liar, pants on fire"

moranegg added inline comments.Feb 18 2022, 4:34 PM

swh/deposit/utils.py
180	haha

hmm I'll probably rewrite all these utils with XPath at some point

This revision is now accepted and ready to land.Feb 21 2022, 1:41 PM

Rebase

hmm I'll probably rewrite all these utils with XPath at some point

yeah, that'd be fine.

Do you have a specific library in mind?

Build is green

Patch application report for D7200 (id=26128)

Rebasing onto e1549dc0d3...

Current branch diff-target is up to date.

Changes applied before test

commit 40adc8c23b98b24bfdc5526d9e6b8bfe2d198c39
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Feb 18 14:35:49 2022 +0100

    deposit: Add utils to parse metadata provenance from atom entry file
    
    Related to T3677

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/706/ for more details.

Harbormaster completed remote builds in B26999: Diff 26128.Feb 21 2022, 2:38 PM

Closed by commit rDDEP40adc8c23b98: deposit: Add utils to parse metadata provenance from atom entry file (authored by ardumont). · Explain WhyFeb 21 2022, 2:39 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDDEP40adc8c23b98: deposit: Add utils to parse metadata provenance from atom entry file.

ardumont added a child revision: D7209: api.checks: Warn when suggested fields are missing from metadata.Feb 21 2022, 4:02 PM