Differential D7171

origin_save: Add support for bzr visit type
ClosedPublic
Actions

Authored by anlambert on Feb 14 2022, 2:22 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPSaa948f683125: origin_save: Add support for bzr visit type

Summary

Add support for Bazaar repository loading in Save Code Now.

Diff Detail

Repository

rDWAPPS Web applications

Branch

save-code-now-bzr

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26863
Build 41997: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 41996: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	669 ms	Jenkins > should list privileged visit types when connected as ambassador::Tests / Cypress tests / Run cypress tests / Origin Save Tests should list privileged visit types when connected as ambassador AssertionError: expected [ Array(6) ] to deeply equal [ Array(5) ] at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-save.spec.js:615:30)
	972 ms	Jenkins > should list unprivileged visit types when connected as unprivileged user::Tests / Cypress tests / Run cypress tests / Origin Save Tests should list unprivileged visit types when connected as unprivileged user AssertionError: expected [ 'bzr', 'cvs', 'git', 'hg', 'svn' ] to deeply equal [ 'cvs', 'git', 'hg', 'svn' ] at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-save.spec.js:607:30)
	433 ms	Jenkins > should list unprivileged visit types when not connected::Tests / Cypress tests / Run cypress tests / Origin Save Tests should list unprivileged visit types when not connected AssertionError: expected [ 'bzr', 'cvs', 'git', 'hg', 'svn' ] to deeply equal [ 'cvs', 'git', 'hg', 'svn' ] at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-save.spec.js:599:30)
	223 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_deposit::Tests / Python tests / test_deposit_admin_view_available_for_staff_user
	230 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_deposit::Tests / Python tests / test_deposit_admin_view_available_for_user_with_permission
		View Full Test Results (3 Failed · 831 Passed · 5 Skipped)

Event Timeline

anlambert created this revision.Feb 14 2022, 2:22 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 14 2022, 2:22 PM

Build has FAILED

Patch application report for D7171 (id=25988)

Rebasing onto 09b8522455...

Current branch diff-target is up to date.

Changes applied before test

commit 5b36891331118eee1a0854a1fd21226702504c33
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Feb 14 14:22:11 2022 +0100

    origin_save: Add support for bzr visit type
    
    Add support for Bazaar repository loading in Save Code Now.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1382/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1382/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 14 2022, 2:38 PM

Harbormaster failed remote builds in B26863: Diff 25988!

Fix cypress tests

Really fix cypress tests

Build has FAILED

Patch application report for D7171 (id=25989)

Rebasing onto 09b8522455...

Current branch diff-target is up to date.

Changes applied before test

commit 705dd0611f99adbcf0b908b07ec991ce076d57b0
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Feb 14 14:22:11 2022 +0100

    origin_save: Add support for bzr visit type
    
    Add support for Bazaar repository loading in Save Code Now.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1383/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1383/console

Harbormaster failed remote builds in B26864: Diff 25989!Feb 14 2022, 3:07 PM

Build is green

Patch application report for D7171 (id=25991)

Rebasing onto 09b8522455...

Current branch diff-target is up to date.

Changes applied before test

commit aa948f683125ac668aafae9d7fe246ef6b05b392
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Feb 14 14:22:11 2022 +0100

    origin_save: Add support for bzr visit type
    
    Add support for Bazaar repository loading in Save Code Now.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1384/ for more details.

Harbormaster completed remote builds in B26866: Diff 25991.Feb 14 2022, 3:13 PM

anlambert requested review of this revision.Feb 14 2022, 3:13 PM

ardumont accepted this revision.Feb 14 2022, 3:26 PM

This revision is now accepted and ready to land.Feb 14 2022, 3:26 PM

Closed by commit rDWAPPSaa948f683125: origin_save: Add support for bzr visit type (authored by anlambert). · Explain WhyFeb 14 2022, 3:46 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSaa948f683125: origin_save: Add support for bzr visit type.