Differential D7144

Add missing slots to HashableObjectWithManifest
ClosedPublic
Actions

Authored by vlorentz on Feb 10 2022, 12:13 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDMOD839e0dcdcb36: Add missing __slots__ to HashableObjectWithManifest

Summary

This should slightly reduce the memory used by dir/rev/rel objects

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 10 2022, 12:13 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 10 2022, 12:13 PM

Build is green

Patch application report for D7144 (id=25888)

Rebasing onto a0674ad802...

Current branch diff-target is up to date.

Changes applied before test

commit 839e0dcdcb36a5e563a946c8b4d1a8f06478640f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Feb 10 12:13:00 2022 +0100

    Add missing __slots__ to HashableObjectWithManifest
    
    This should slightly reduce the memory used by dir/rev/rel objects

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/457/ for more details.

Harbormaster completed remote builds in B26728: Diff 25888.Feb 10 2022, 12:15 PM

vlorentz requested review of this revision.Feb 10 2022, 12:15 PM

ardumont accepted this revision.Feb 10 2022, 2:13 PM

This revision is now accepted and ready to land.Feb 10 2022, 2:13 PM

Closed by commit rDMOD839e0dcdcb36: Add missing __slots__ to HashableObjectWithManifest (authored by vlorentz). · Explain WhyFeb 10 2022, 2:14 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDMOD839e0dcdcb36: Add missing __slots__ to HashableObjectWithManifest.