Use `branch` instead of `clone`
ClosedPublic
Actions

Authored by Alphare on Feb 9 2022, 2:54 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDBZR080db96f1190: Use `branch` instead of `clone`

Summary

clone was introduced with Breezy 3.1.0. For our purposes, branch
will do just fine since we don't want to get colocated branches (but
only one branch per origin) and we can get the same "no tree" behavior
with a simple flag.

Diff Detail

Repository

rDLDBZR BZR loader

Branch

clone

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26700
Build 41754: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 41753: arc lint + arc unit

Event Timeline

Alphare created this revision.Feb 9 2022, 2:54 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 9 2022, 2:54 PM

Build has FAILED

Patch application report for D7133 (id=25854)

Rebasing onto 078fb50296...

Current branch diff-target is up to date.

Changes applied before test

commit 5741ffd12c7830684303eb75d8d1176fea67e7ff
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Wed Feb 9 14:51:05 2022 +0100

    Use `branch` instead of `clone`
    
    `clone` was introduced with Breezy 3.1.0. For our purposes, `branch`
    will do just fine since we don't want to get colocated branches (but
    only one branch per origin) and we can get the same "no tree" behavior
    with a simple flag.

Link to build: https://jenkins.softwareheritage.org/job/DLDBZR/job/tests-on-diff/32/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBZR/job/tests-on-diff/32/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 9 2022, 2:58 PM

Harbormaster failed remote builds in B26696: Diff 25854!

ardumont mentioned this in T3915: Deploy Bzr loader to the staging environment.Feb 9 2022, 3:07 PM

Fix dir reuse

Build is green

Patch application report for D7133 (id=25858)

Rebasing onto 078fb50296...

Current branch diff-target is up to date.

Changes applied before test

commit 080db96f11900080399ec423d1b12b524b86c480
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Wed Feb 9 14:51:05 2022 +0100

    Use `branch` instead of `clone`
    
    `clone` was introduced with Breezy 3.1.0. For our purposes, `branch`
    will do just fine since we don't want to get colocated branches (but
    only one branch per origin). We can get the same "no tree" and directory
    reuse behaviors with a simple flag.

See https://jenkins.softwareheritage.org/job/DLDBZR/job/tests-on-diff/33/ for more details.

Harbormaster completed remote builds in B26700: Diff 25858.Feb 9 2022, 3:20 PM

Alphare requested review of this revision.Feb 9 2022, 3:20 PM

ardumont accepted this revision.Feb 9 2022, 3:22 PM

This revision is now accepted and ready to land.Feb 9 2022, 3:22 PM

Alphare mentioned this in D7132: bzr: Allow cloning with breezy version without cmd_clone function.Feb 9 2022, 3:26 PM

Closed by commit rDLDBZR080db96f1190: Use `branch` instead of `clone` (authored by Alphare). · Explain WhyFeb 9 2022, 3:27 PM

This revision was automatically updated to reflect the committed changes.

Alphare added a commit: rDLDBZR080db96f1190: Use `branch` instead of `clone`.