Allow cooking release objects via the API
AcceptedPublic
Actions

Authored by vlorentz on Feb 8 2022, 2:02 PM.

Details

Reviewers

Group Reviewers

Summary

No snapshots yet; they are very costly to cook when swh-graph is
outdated; and currently it is outdated for many objects.

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26671
Build 41707: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 41706: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	168 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_vault::Tests / Python tests / test_api_vault_cook_error[git_bare-rel-False] api_client = <rest_framework.test.APIClient object at 0x7f5624a3f0b8> mocker = <pytest_mock.plugin.MockerFixture object at 0x7f5624a3f748> bundle_type = 'git_bare', swhid_type = 'rel', hint = False
	221 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_deposit::Tests / Python tests / test_deposit_admin_view_available_for_staff_user
	331 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_deposit::Tests / Python tests / test_deposit_admin_view_available_for_user_with_permission
	153 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_deposit::Tests / Python tests / test_deposit_admin_view_not_available_for_anonymous_user
	1,008 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_accept_pending_save_request
		View Full Test Results (1 Failed · 831 Passed · 5 Skipped)

Event Timeline

vlorentz created this revision.Feb 8 2022, 2:02 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 8 2022, 2:02 PM

Build has FAILED

Patch application report for D7122 (id=25827)

Could not rebase; Attempt merge onto b0bba742ec...

Updating b0bba742..3cdf6392
Fast-forward
 cypress/integration/vault.spec.js                  | 21 +++++++++++
 swh/web/api/views/vault.py                         | 21 ++++++-----
 swh/web/templates/includes/vault-create-tasks.html | 41 +++++++++-------------
 3 files changed, 50 insertions(+), 33 deletions(-)

Changes applied before test

commit 3cdf63922dba3a0dd34258ce3cbceb5620d11559
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Feb 8 14:02:04 2022 +0100

    Allow cooking release objects via the API
    
    No snapshots yet; they are very costly to cook when swh-graph is
    outdated; and currently it is outdated for many objects.

commit d891b0465a7cae907e721307fed044f7e7a918b7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Feb 8 11:55:15 2022 +0100

    Allow vault cooking from the UI
    
    The vault is now about as stable as it can be in the short term,
    so I think it is time to finally make this available to everyone,
    without having to go throught the API manually.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1363/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1363/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 8 2022, 2:17 PM

Harbormaster failed remote builds in B26671: Diff 25827!

rebase + update tests

Build is green

Patch application report for D7122 (id=25833)

Could not rebase; Attempt merge onto b0bba742ec...

Updating b0bba742..b0b4e693
Fast-forward
 cypress/integration/vault.spec.js                  | 23 ++++++++----
 swh/web/api/views/vault.py                         | 21 ++++++-----
 swh/web/templates/includes/vault-create-tasks.html | 41 +++++++++-------------
 swh/web/tests/api/views/test_vault.py              |  4 +--
 4 files changed, 48 insertions(+), 41 deletions(-)

Changes applied before test

commit b0b4e693b737748234d06f29604f6391cb33482b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Feb 8 14:02:04 2022 +0100

    Allow cooking release objects via the API
    
    No snapshots yet; they are very costly to cook when swh-graph is
    outdated; and currently it is outdated for many objects.

commit 5b517e6e4d55c74d508d39f850cbe4b6d68c1e20
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Feb 8 11:55:15 2022 +0100

    Allow vault cooking from the UI
    
    The vault is now about as stable as it can be in the short term,
    so I think it is time to finally make this available to everyone,
    without having to go throught the API manually.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1366/ for more details.

Harbormaster completed remote builds in B26676: Diff 25833.Feb 8 2022, 4:06 PM

vlorentz requested review of this revision.Feb 8 2022, 4:06 PM

Looks like release objects cannot be currently cooked, I guess you have another diff coming to add such support ?