Page MenuHomeSoftware Heritage
Differential D7120

Allow vault cooking from the UI
Needs RevisionPublic
Actions

Authored by vlorentz on Feb 8 2022, 11:56 AM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Maniphest Tasks
T3504: Make the git-bare cooker publicly available
Summary

The vault is now about as stable as it can be in the short term,
so I think it is time to finally make this available to everyone,
without having to go throught the API manually.

Closes T3504.
Depends on T3918.

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26674
Build 41711: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 41710: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
173 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_vault::Tests / Python tests / test_api_vault_cook_error[git_bare-rel-False]
api_client = <rest_framework.test.APIClient object at 0x7f67be756fd0> mocker = <pytest_mock.plugin.MockerFixture object at 0x7f67be756ef0> bundle_type = 'git_bare', swhid_type = 'rel', hint = False
237 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_deposit::Tests / Python tests / test_deposit_admin_view_available_for_staff_user
333 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_deposit::Tests / Python tests / test_deposit_admin_view_available_for_user_with_permission
166 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_deposit::Tests / Python tests / test_deposit_admin_view_not_available_for_anonymous_user
1,013 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_accept_pending_save_request
View Full Test Results (1 Failed · 831 Passed · 5 Skipped)

Event Timeline

vlorentz created this revision.Feb 8 2022, 11:56 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 8 2022, 11:56 AM
vlorentz added a child revision: D7121: Remove role swh.vault.git_bare.ui.Feb 8 2022, 12:01 PM
swh-public-ci added a comment.Feb 8 2022, 12:17 PM

Build was aborted

Patch application report for D7120 (id=25817)

Rebasing onto b0bba742ec...

Current branch diff-target is up to date.
Changes applied before test
commit 03c66c7acedcbc354c9a83f67c71132e960c9e37
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Feb 8 11:55:15 2022 +0100

    Allow vault cooking from the UI
    
    The vault is now about as stable as it can be in the short term,
    so I think it is time to finally make this available to everyone,
    without having to go throught the API manually.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1359/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1359/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 8 2022, 12:17 PM
Harbormaster failed remote builds in B26661: Diff 25817!
vlorentz updated this revision to Diff 25820.Feb 8 2022, 12:44 PM

fix test

swh-public-ci added a comment.Feb 8 2022, 1:06 PM

Build was aborted

Patch application report for D7120 (id=25820)

Rebasing onto b0bba742ec...

Current branch diff-target is up to date.
Changes applied before test
commit 177eb6b56be826a8e1f5e6ed2b862be2cbb463b3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Feb 8 11:55:15 2022 +0100

    Allow vault cooking from the UI
    
    The vault is now about as stable as it can be in the short term,
    so I think it is time to finally make this available to everyone,
    without having to go throught the API manually.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1361/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1361/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 8 2022, 1:06 PM
Harbormaster failed remote builds in B26664: Diff 25820!
vlorentz updated this revision to Diff 25826.Feb 8 2022, 1:36 PM

fix more tests

swh-public-ci added a comment.Feb 8 2022, 1:52 PM

Build is green

Patch application report for D7120 (id=25826)

Rebasing onto b0bba742ec...

Current branch diff-target is up to date.
Changes applied before test
commit d891b0465a7cae907e721307fed044f7e7a918b7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Feb 8 11:55:15 2022 +0100

    Allow vault cooking from the UI
    
    The vault is now about as stable as it can be in the short term,
    so I think it is time to finally make this available to everyone,
    without having to go throught the API manually.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1362/ for more details.

Harbormaster completed remote builds in B26670: Diff 25826.Feb 8 2022, 1:52 PM
vlorentz requested review of this revision.Feb 8 2022, 1:52 PM
anlambert requested changes to this revision.Feb 8 2022, 2:02 PM
anlambert added a subscriber: anlambert.

Cypress tests can be simplified before landing this.

cypress/integration/vault.spec.js
131–134

You can replace these two instructions by:

checkVaultCookingTask('as tarball');

Same thing for all your changes below.

432

You need to remove that line once using chackVaultCookingTask above as that call is already wrapped in it.

This revision now requires changes to proceed.Feb 8 2022, 2:02 PM
vlorentz updated this revision to Diff 25830.Feb 8 2022, 3:46 PM

simplify a couple of tests

vlorentz updated this revision to Diff 25831.Feb 8 2022, 3:47 PM

oops, included wrong commit

anlambert requested changes to this revision.Feb 8 2022, 3:55 PM
anlambert added inline comments.
cypress/integration/vault.spec.js
156–162

You can also replace this one and the others below, I have tested it works.

This revision now requires changes to proceed.Feb 8 2022, 3:55 PM
swh-public-ci added a comment.Feb 8 2022, 4:02 PM

Build has FAILED

Patch application report for D7120 (id=25830)

Rebasing onto b0bba742ec...

Current branch diff-target is up to date.
Changes applied before test
commit 57298fe585f7936024022167a03cc106b6903d4e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Feb 8 14:02:04 2022 +0100

    Allow cooking release objects via the API
    
    No snapshots yet; they are very costly to cook when swh-graph is
    outdated; and currently it is outdated for many objects.

commit d891b0465a7cae907e721307fed044f7e7a918b7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Feb 8 11:55:15 2022 +0100

    Allow vault cooking from the UI
    
    The vault is now about as stable as it can be in the short term,
    so I think it is time to finally make this available to everyone,
    without having to go throught the API manually.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1364/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1364/console

Harbormaster failed remote builds in B26674: Diff 25830!Feb 8 2022, 4:02 PM
swh-public-ci added a comment.Feb 8 2022, 4:03 PM

Build is green

Patch application report for D7120 (id=25831)

Rebasing onto b0bba742ec...

Current branch diff-target is up to date.
Changes applied before test
commit 5b517e6e4d55c74d508d39f850cbe4b6d68c1e20
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Feb 8 11:55:15 2022 +0100

    Allow vault cooking from the UI
    
    The vault is now about as stable as it can be in the short term,
    so I think it is time to finally make this available to everyone,
    without having to go throught the API manually.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1365/ for more details.

Harbormaster completed remote builds in B26675: Diff 25831.Feb 8 2022, 4:03 PM
vlorentz added inline comments.Feb 10 2022, 11:07 AM
cypress/integration/vault.spec.js
156–162

How come? Isn't the test supposed to click the Ok button inbetween?

vlorentz added a comment.EditedFeb 10 2022, 11:11 AM

We are going to postpone this diff until T3924 is resolved one way or another.

Revision Contents
Changeset List

PathSize
cypress/
integration/
23 lines
swh/
web/
api/
views/
21 lines
templates/
includes/
41 lines

Diff 25830

View Options

cypress/integration/vault.spec.js

Loading...
View Options

swh/web/api/views/vault.py

Loading...
View Options

swh/web/templates/includes/vault-create-tasks.html

Loading...
About · Developer information · Legal