mailmap: make the update view only update a single object
ClosedPublic
Actions

Authored by vlorentz on Feb 5 2022, 12:56 AM.

Details

Reviewers

anlambert
olasd

Commits

rDWAPPSd4ca7bede2dc: mailmap: Add/fix tests
rDWAPPS69aab8182524: mailmap: make the update view only update a single object

Summary

the current implementation updates all objects, which seems off

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26571
Build 41559: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 41558: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	282 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.auth.test_mailmap::Tests / Python tests / test_mailmap_endpoints_error_response api_client = <rest_framework.test.APIClient object at 0x7f5e6addcb38> mailmap_user = <User: johndoe>
	218 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_deposit::Tests / Python tests / test_deposit_admin_view_available_for_staff_user
	223 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_deposit::Tests / Python tests / test_deposit_admin_view_available_for_user_with_permission
	158 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_deposit::Tests / Python tests / test_deposit_admin_view_not_available_for_anonymous_user
	970 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_accept_pending_save_request
		View Full Test Results (1 Failed · 828 Passed · 5 Skipped)

Event Timeline

olasd created this revision.Feb 5 2022, 12:56 AM

Build has FAILED

Patch application report for D7094 (id=25741)

Rebasing onto b32e24e920...

Current branch diff-target is up to date.

Changes applied before test

commit b55a035142cb62371e8363c06fbbb5a5b0e40aec
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Sat Feb 5 00:55:22 2022 +0100

    mailmap: make the update view only update a single object

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1340/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1340/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 5 2022, 1:12 AM

Harbormaster failed remote builds in B26571: Diff 25741!

Here is a fix + an extra test:

(removed, I commandeered the diff and added it)

vlorentz commandeered this revision.Feb 5 2022, 11:13 AM

vlorentz edited reviewers, added: olasd; removed: vlorentz.

mailmap: Add/fix tests

Build is green

Patch application report for D7094 (id=25742)

Rebasing onto b32e24e920...

Current branch diff-target is up to date.

Changes applied before test

commit d4ca7bede2dcf62214d0289671cb9e44a3b66329
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Sat Feb 5 11:16:54 2022 +0100

    mailmap: Add/fix tests

commit 69aab8182524f9e3608d264499fb7b425d4e5352
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Sat Feb 5 00:55:22 2022 +0100

    mailmap: make the update view only update a single object

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1341/ for more details.

Harbormaster completed remote builds in B26572: Diff 25742.Feb 5 2022, 11:31 AM

vlorentz requested review of this revision.Feb 5 2022, 11:31 AM

Looks good to me.

This revision is now accepted and ready to land.Feb 7 2022, 11:19 AM

Closed by commit rDWAPPS69aab8182524: mailmap: make the update view only update a single object (authored by olasd, committed by vlorentz). · Explain WhyFeb 7 2022, 11:25 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDWAPPS69aab8182524: mailmap: make the update view only update a single object.

vlorentz added a commit: rDWAPPSd4ca7bede2dc: mailmap: Add/fix tests.