Differential D7080

tests: Remove use of mocks in common/test_origin_visits
ClosedPublic
Actions

Authored by anlambert on Feb 3 2022, 7:10 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPSe72b1e7a9d18: tests: Remove use of mocks in common/test_origin_visits

Summary

Use of mocks in tests should be avoided when possible.

Diff Detail

Repository

rDWAPPS Web applications

Branch

origin-visits-tests-remove-mocks

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26514
Build 41464: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 41463: arc lint + arc unit

Event Timeline

anlambert created this revision.Feb 3 2022, 7:10 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 3 2022, 7:10 PM

Build is green

Patch application report for D7080 (id=25683)

Rebasing onto 84ba3c0df5...

Current branch diff-target is up to date.

Changes applied before test

commit e72b1e7a9d183b82960ed1dca8544cab7492cc89
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Feb 3 19:09:00 2022 +0100

    tests: Remove use of mocks in common/test_origin_visits

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1323/ for more details.

Harbormaster completed remote builds in B26514: Diff 25683.Feb 3 2022, 7:27 PM

anlambert requested review of this revision.Feb 3 2022, 7:27 PM

ardumont accepted this revision.Feb 3 2022, 7:57 PM

This revision is now accepted and ready to land.Feb 3 2022, 7:57 PM

ardumont mentioned this in D7066: origin_visits: Reuse cache entries if present.Feb 3 2022, 8:03 PM

ardumont added a child revision: D7066: origin_visits: Reuse cache entries if present.Feb 4 2022, 9:02 AM

Closed by commit rDWAPPSe72b1e7a9d18: tests: Remove use of mocks in common/test_origin_visits (authored by anlambert). · Explain WhyFeb 4 2022, 11:11 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSe72b1e7a9d18: tests: Remove use of mocks in common/test_origin_visits.

ardumont mentioned this in D7078: Find latest origin visit status by date instead of visits filtering.Feb 4 2022, 11:29 AM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

web/

tests/

common/

test_origin_visits.py

179 lines

100%

Diff 25683

View Options

swh/web/tests/common/test_origin_visits.py

tests: Remove use of mocks in common/test_origin_visitsClosedPublicActions