Page MenuHomeSoftware Heritage
Differential D7060

preparation refactoring for following diffs
ClosedPublic
Actions

Authored by douardda on Feb 2 2022, 1:49 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T3894: Add a 'swh db upgrade' cli
Commits
rDCORE459da96c1e6b: Move utility functions from cli.db to db.db_utils
rDCORE932eed4863ba: Remove the old and unused log-schema.sql file
Summary

Remove the old and unused log-schema.sql file

Move utility functions from cli.db to db.db_utils

Related to T3894.

Diff Detail

Event Timeline

douardda created this revision.Feb 2 2022, 1:49 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 2 2022, 1:49 PM
douardda added a child revision: D7061: Make `swh db init` retrieve the db cnx uri from the config file.Feb 2 2022, 1:49 PM
swh-public-ci added a comment.Feb 2 2022, 1:50 PM

Build has FAILED

Patch application report for D7060 (id=25610)

Rebasing onto aba5c80765...

Current branch diff-target is up to date.
Changes applied before test
commit 6c665e38e6579a02839eef6a8a6b60dc332be51c
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jan 28 14:49:41 2022 +0100

    Move utility functions from cli.db to db.db_utils

commit e4117fcf51a256c5b708f909c818f452c794c0f8
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jan 28 10:07:35 2022 +0100

    Remove the old and unused log-schema.sql file

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/265/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/265/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 2 2022, 1:50 PM
Harbormaster failed remote builds in B26440: Diff 25610!
douardda updated this revision to Diff 25617.Feb 2 2022, 2:34 PM

fix

swh-public-ci added a comment.Feb 2 2022, 2:35 PM

Build is green

Patch application report for D7060 (id=25617)

Rebasing onto aba5c80765...

Current branch diff-target is up to date.
Changes applied before test
commit d3b7b081fd3eda460d11d1d6d70f2b52fa3e0ef3
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jan 28 14:49:41 2022 +0100

    Move utility functions from cli.db to db.db_utils

commit e4117fcf51a256c5b708f909c818f452c794c0f8
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jan 28 10:07:35 2022 +0100

    Remove the old and unused log-schema.sql file

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/270/ for more details.

Harbormaster completed remote builds in B26447: Diff 25617.Feb 2 2022, 2:35 PM
douardda requested review of this revision.Feb 2 2022, 2:35 PM
vlorentz accepted this revision.Feb 2 2022, 3:06 PM
vlorentz added a subscriber: vlorentz.

I don't see why, but ok

swh/core/db/db_utils.py
345

can make this toplevel now

379

ditto

This revision is now accepted and ready to land.Feb 2 2022, 3:06 PM
douardda added inline comments.Feb 2 2022, 3:25 PM
swh/core/db/db_utils.py
345

good catch

douardda updated this revision to Diff 25632.Feb 2 2022, 3:30 PM

move (forgotten) import stmts top level (thx vlorentz)

swh-public-ci added a comment.Feb 2 2022, 3:31 PM

Build is green

Patch application report for D7060 (id=25632)

Rebasing onto aba5c80765...

Current branch diff-target is up to date.
Changes applied before test
commit de1c894e3fa88b3e1e2ba1e7c7dbfc77f7ea4b51
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jan 28 14:49:41 2022 +0100

    Move utility functions from cli.db to db.db_utils

commit e4117fcf51a256c5b708f909c818f452c794c0f8
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jan 28 10:07:35 2022 +0100

    Remove the old and unused log-schema.sql file

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/285/ for more details.

Harbormaster completed remote builds in B26462: Diff 25632.Feb 2 2022, 3:31 PM
douardda updated this revision to Diff 25928.Feb 11 2022, 12:19 PM

rebase

swh-public-ci added a comment.Feb 11 2022, 12:21 PM

Build is green

Patch application report for D7060 (id=25928)

Rebasing onto 5046a95f05...

Current branch diff-target is up to date.
Changes applied before test
commit 459da96c1e6b6044deb874e0e668606c3da3e43c
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jan 28 14:49:41 2022 +0100

    Move utility functions from cli.db to db.db_utils

commit 932eed4863baedf011b4a59d0227331d37db1dfd
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jan 28 10:07:35 2022 +0100

    Remove the old and unused log-schema.sql file

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/295/ for more details.

Harbormaster completed remote builds in B26805: Diff 25928.Feb 11 2022, 12:21 PM
Closed by commit rDCORE932eed4863ba: Remove the old and unused log-schema.sql file (authored by douardda). · Explain WhyFeb 11 2022, 12:52 PM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDCORE932eed4863ba: Remove the old and unused log-schema.sql file.
douardda added a commit: rDCORE459da96c1e6b: Move utility functions from cli.db to db.db_utils.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
1 line--
swh/
core/
cli/
164 lines87%
Loading...
db/
174 lines52%
Loading...
tests/
2 lines99%
Loading...
sql/
--

Diff 25928

View Options

MANIFEST.in

Loading...
View Options

swh/core/cli/db.py

Loading...
View Options

swh/core/db/db_utils.py

Loading...
View Options

swh/core/db/tests/test_cli.py

Loading...
View Options

swh/core/sql/log-schema.sql

Loading...
About · Developer information · Legal