Differential D7048

base_check: Add typing annotation to constructor
ClosedPublic
Actions

Authored by ardumont on Jan 28 2022, 4:40 PM.

Details

Reviewers

vsellier

Group Reviewers

Reviewers

Commits

rDICP742053536f29: base_check: Add typing annotation to constructor

Diff Detail

Repository

rDICP Icinga plugins

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26388
Build 41252: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 41251: arc lint + arc unit

Event Timeline

ardumont created this revision.Jan 28 2022, 4:40 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 28 2022, 4:40 PM

Build is green

Patch application report for D7048 (id=25557)

Rebasing onto c4f025e849...

Current branch diff-target is up to date.

Changes applied before test

commit 742053536f2998469daf3a38125c060c5e179bd6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jan 28 16:39:56 2022 +0100

    base_check: Add typing annotation to constructor

See https://jenkins.softwareheritage.org/job/DICP/job/tests-on-diff/42/ for more details.

Harbormaster completed remote builds in B26388: Diff 25557.Jan 28 2022, 4:41 PM

ardumont requested review of this revision.Jan 28 2022, 4:41 PM

Thanks for making mypy happy ;)

This revision is now accepted and ready to land.Jan 28 2022, 4:46 PM

Closed by commit rDICP742053536f29: base_check: Add typing annotation to constructor (authored by ardumont). · Explain WhyJan 28 2022, 4:46 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDICP742053536f29: base_check: Add typing annotation to constructor.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

icinga_plugins/

base_check.py

17 lines

100%

Diff 25557

View Options

swh/icinga_plugins/base_check.py

base_check: Add typing annotation to constructorClosedPublicActions