Differential D7031

the key has a fixed len: do not hardcode it
ClosedPublic
Actions

Authored by dachary on Jan 25 2022, 3:19 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDOPHd79745c582c8: the key has a fixed len: do not hardcode it

Summary

and add a safeguard in case the caller provides a key with the wrong size

Diff Detail

Repository

rDOPH Perfect Hash algorithm

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26327
Build 41165: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 41164: arc lint + arc unit

Event Timeline

dachary created this revision.Jan 25 2022, 3:19 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 25 2022, 3:19 PM

Build is green

Patch application report for D7031 (id=25495)

Rebasing onto 7fd6dbac76...

Current branch diff-target is up to date.

Changes applied before test

commit d79745c582c898202d02e1583240ca94009d962a
Author: Loïc Dachary <loic@dachary.org>
Date:   Tue Jan 25 15:17:23 2022 +0100

    the key has a fixed len: do not hardcode it
    
    and add a safeguard in case the caller provides a key with the wrong size

See https://jenkins.softwareheritage.org/job/DOPH/job/tests-on-diff/25/ for more details.

Harbormaster completed remote builds in B26327: Diff 25495.Jan 25 2022, 3:20 PM

dachary requested review of this revision.Jan 25 2022, 3:20 PM