Page MenuHomeSoftware Heritage
Differential D7030

implement statistics collection during benchmarks
ClosedPublic
Actions

Authored by dachary on Jan 25 2022, 10:55 AM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDOBJS7b5538279be0: implement statistics collection during benchmarks
Summary

statistics on reads and writes are written in CSV files. At the end of the benchmark they are merged together to display overall performances.

Relates to: T3531

Diff Detail

Repository
rDOBJS Object storage
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26319
Build 41152: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 41151: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
168 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.objstorage.tests.test_objstorage_api.TestRemoteObjStorage::test_add_stream
self = <swh.objstorage.tests.test_objstorage_api.TestRemoteObjStorage testMethod=test_add_stream> def test_add_stream(self):
3 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.objstorage.tests.test_multiplexer_filter.MixinTestReadFilter::test_can_check
1 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.objstorage.tests.test_multiplexer_filter.MixinTestReadFilter::test_can_contains
1 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.objstorage.tests.test_multiplexer_filter.MixinTestReadFilter::test_can_get
30 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.objstorage.tests.test_multiplexer_filter.MixinTestReadFilter::test_can_get_random
View Full Test Results (1 Failed · 700 Passed · 9 Skipped)

Event Timeline

dachary created this revision.Jan 25 2022, 10:55 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 25 2022, 10:55 AM
swh-public-ci added a comment.Jan 25 2022, 10:58 AM

Build has FAILED

Patch application report for D7030 (id=25485)

Rebasing onto 554c12a851...

Current branch diff-target is up to date.
Changes applied before test
commit 52963a290849c8ba83234d0299196e2b117460c0
Author: Loïc Dachary <loic@dachary.org>
Date:   Mon Jan 24 22:09:19 2022 +0100

    implement statistics collection during benchmarks

Link to build: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/112/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/112/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 25 2022, 10:58 AM
Harbormaster failed remote builds in B26319: Diff 25485!
dachary updated this revision to Diff 25486.Jan 25 2022, 11:08 AM

no float, int is better

swh-public-ci added a comment.Jan 25 2022, 11:10 AM

Build is green

Patch application report for D7030 (id=25486)

Rebasing onto 554c12a851...

Current branch diff-target is up to date.
Changes applied before test
commit 51a93ec950a1a706583cfae7c023928743731f6d
Author: Loïc Dachary <loic@dachary.org>
Date:   Mon Jan 24 22:09:19 2022 +0100

    implement statistics collection during benchmarks

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/113/ for more details.

Harbormaster completed remote builds in B26320: Diff 25486.Jan 25 2022, 11:10 AM
dachary requested review of this revision.Jan 25 2022, 11:10 AM
dachary updated this revision to Diff 25487.Jan 25 2022, 11:25 AM

remove spurious print

swh-public-ci added a comment.Jan 25 2022, 11:27 AM

Build is green

Patch application report for D7030 (id=25487)

Rebasing onto 554c12a851...

Current branch diff-target is up to date.
Changes applied before test
commit 2d6f6a20d5091885efe7023dece26c4d733504ff
Author: Loïc Dachary <loic@dachary.org>
Date:   Mon Jan 24 22:09:19 2022 +0100

    implement statistics collection during benchmarks

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/114/ for more details.

Harbormaster completed remote builds in B26321: Diff 25487.Jan 25 2022, 11:27 AM
vlorentz added a subscriber: vlorentz.Jan 25 2022, 12:04 PM
vlorentz added inline comments.
swh/objstorage/backends/winery/stats.py
29–55

could probably moved to __init__

57–63

is this split just for tests?

swh/objstorage/tests/test_objstorage_winery.py
383
swh/objstorage/tests/winery_benchmark.py
23–26

we prefer collaborator patterns to inheritance for this sort of stuff

winery-test-environment/requirements.txt
4

wut, why PyQt?

dachary updated this revision to Diff 25489.Jan 25 2022, 12:58 PM
dachary marked 5 inline comments as done.

address review comments

swh/objstorage/backends/winery/stats.py
29–55

Done.

57–63

For symmetry: moved to del since _init is now in init

swh/objstorage/tests/test_objstorage_winery.py
383

Cute, thanks for the tip!

swh/objstorage/tests/winery_benchmark.py
23–26

Thanks for the advice, changed accordingly.

winery-test-environment/requirements.txt
4

for rendering the graphs in a window. That's what plt.show() is for in render-stats.py.

vlorentz accepted this revision.Jan 25 2022, 1:00 PM

doesn't matplotlib work with the built-in tkinter by default?

This revision is now accepted and ready to land.Jan 25 2022, 1:00 PM
swh-public-ci added a comment.Jan 25 2022, 1:01 PM

Build is green

Patch application report for D7030 (id=25489)

Rebasing onto 554c12a851...

Current branch diff-target is up to date.
Changes applied before test
commit 7b5538279be0001b84e0499b869d65caff908fad
Author: Loïc Dachary <loic@dachary.org>
Date:   Mon Jan 24 22:09:19 2022 +0100

    implement statistics collection during benchmarks

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/115/ for more details.

Harbormaster completed remote builds in B26323: Diff 25489.Jan 25 2022, 1:01 PM
Closed by commit rDOBJS7b5538279be0: implement statistics collection during benchmarks (authored by dachary). · Explain WhyJan 25 2022, 1:04 PM
This revision was automatically updated to reflect the committed changes.
dachary added a commit: rDOBJS7b5538279be0: implement statistics collection during benchmarks.

Revision Contents
Changeset List

PathSize
swh/
objstorage/
backends/
winery/
7 lines
92 lines
tests/
5 lines
24 lines
17 lines
winery-test-environment/
14 lines
16 lines
59 lines
3 lines

Diff 25485

View Options

swh/objstorage/backends/winery/objstorage.py

Loading...
View Options

swh/objstorage/backends/winery/stats.py

Loading...
View Options

swh/objstorage/tests/conftest.py

Loading...
View Options

swh/objstorage/tests/test_objstorage_winery.py

Loading...
View Options

swh/objstorage/tests/winery_benchmark.py

Loading...
View Options

winery-test-environment/README.md

Loading...
View Options

winery-test-environment/remote-tox.sh

Loading...
View Options

winery-test-environment/render-stats.py

Loading...
View Options

winery-test-environment/requirements.txt

Loading...
About · Developer information · Legal