It will be replaced by what is currently called 'offset_bytes'
Depends on D6937
Details
Details
- Reviewers
olasd - Group Reviewers
Reviewers - Maniphest Tasks
- T3752: Store/represent time offsets as strings
- Commits
- rDSTO587490574291: Stop using the deprecated 'TimestampWithTimezone.offset' attribute
Will fail because also depends on D7005
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 26254 Build 41046: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 41045: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D7008 (id=25404)
Could not rebase; Attempt merge onto c68a4fd98f...
Merge made by the 'recursive' strategy. requirements-swh.txt | 2 +- swh/storage/backfill.py | 6 --- swh/storage/cassandra/schema.py | 2 - swh/storage/postgresql/converters.py | 49 ++++--------------- swh/storage/tests/algos/test_revisions_walker.py | 54 +++++++------------- .../migrate_extrinsic_metadata/test_debian.py | 12 ++--- swh/storage/tests/storage_data.py | 57 ++++++++-------------- swh/storage/tests/storage_tests.py | 3 +- swh/storage/tests/test_backfill.py | 4 +- swh/storage/tests/test_postgresql_converters.py | 36 ++------------ 10 files changed, 58 insertions(+), 167 deletions(-)
Changes applied before test
commit d16cc5db14c72184cb6ffc60330902f696a16789
Merge: c68a4fd9 90b92bd3
Author: Jenkins user <jenkins@localhost>
Date: Fri Jan 21 12:02:51 2022 +0000
Merge branch 'diff-target' into HEAD
commit 90b92bd32e4cadccd2c9774d1ff521d4d416f250
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Jan 21 13:01:42 2022 +0100
Stop using the deprecated 'TimestampWithTimezone.offset' attribute
It will be replaced by what is currently called 'offset_bytes'
commit 8199ec40ebf319870cba585df50cb0373141b6df
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Wed Jan 12 16:36:24 2022 +0100
Remove 'offset' and 'negative_utc'
This only keeps 'offset_bytes' to store the timezone, to support swh-model
v5.0.0.
However, this keeps writing 'offset' and 'negative_utc' to the postgresql
database, just in case we need to roll back this change.
But they are not read anymore.Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1535/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1535/console
Comment Actions
Build has FAILED
Patch application report for D7008 (id=25411)
Could not rebase; Attempt merge onto c68a4fd98f...
Updating c68a4fd9..c9513788 Fast-forward requirements-swh.txt | 2 +- swh/storage/backfill.py | 6 --- swh/storage/cassandra/schema.py | 2 - swh/storage/postgresql/converters.py | 49 ++++--------------- swh/storage/tests/algos/test_revisions_walker.py | 54 +++++++------------- .../migrate_extrinsic_metadata/test_debian.py | 12 ++--- swh/storage/tests/storage_data.py | 57 ++++++++-------------- swh/storage/tests/storage_tests.py | 3 +- swh/storage/tests/test_backfill.py | 4 +- swh/storage/tests/test_postgresql_converters.py | 36 ++------------ 10 files changed, 58 insertions(+), 167 deletions(-)
Changes applied before test
commit c9513788c64eb5a350e01ec7246ff588a5e54c13
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Jan 21 13:01:42 2022 +0100
Stop using the deprecated 'TimestampWithTimezone.offset' attribute
It will be replaced by what is currently called 'offset_bytes'
commit 2e7413888d8c5fcdaa410a3b76e8a4ee60b74873
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Wed Jan 12 16:36:24 2022 +0100
Remove 'offset' and 'negative_utc'
This only keeps 'offset_bytes' to store the timezone, to support swh-model
v5.0.0.
However, this keeps writing 'offset' and 'negative_utc' to the postgresql
database, just in case we need to roll back this change.
But they are not read anymore.Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1536/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1536/console
Comment Actions
Build is green
Patch application report for D7008 (id=25411)
Rebasing onto 2e7413888d...
Current branch diff-target is up to date.
Changes applied before test
commit c9513788c64eb5a350e01ec7246ff588a5e54c13
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Jan 21 13:01:42 2022 +0100
Stop using the deprecated 'TimestampWithTimezone.offset' attribute
It will be replaced by what is currently called 'offset_bytes'See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1538/ for more details.
Comment Actions
Build is green
Patch application report for D7008 (id=25420)
Rebasing onto 2e7413888d...
Current branch diff-target is up to date.
Changes applied before test
commit 587490574291646e536a103d096df329c87351ad
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Jan 21 13:01:42 2022 +0100
Stop using the deprecated 'TimestampWithTimezone.offset' attribute
It will be replaced by what is currently called 'offset_bytes'See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1539/ for more details.