Differential D6977

replay: Prevent removal of external paths overlapping versioned ones
ClosedPublic
Actions

Authored by anlambert on Jan 19 2022, 2:38 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T611: support for external definitions in the svn/subversion loader

Commits

rDLDSVN11740ebc2993: replay: Prevent removal of external paths overlapping versioned ones

Summary

Some external paths might have been removed in the current replayed
revision by a delete operation on an overlapping versioned path so
we need to restore them or the reconstructed filesystem will differ
with the one obtained by a svn export operation on that revision.

Related to T611

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26161
Build 40892: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 40891: arc lint + arc unit

Event Timeline

anlambert created this revision.Jan 19 2022, 2:38 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 19 2022, 2:38 PM

Build is green

Patch application report for D6977 (id=25305)

Rebasing onto 5df02d6aae...

Current branch diff-target is up to date.

Changes applied before test

commit 11740ebc29934d600b196144724ed33679596b88
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Jan 19 14:34:53 2022 +0100

    replay: Prevent removal of external paths overlapping versioned ones
    
    Some external paths might have been removed in the current replayed
    revision by a delete operation on an overlapping versioned path so
    we need to restore them or the reconstructed filesystem will differ
    with the one obtained by a svn export operation on that revision.
    
    Related to T611

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/261/ for more details.

Harbormaster completed remote builds in B26161: Diff 25305.Jan 19 2022, 2:40 PM

anlambert requested review of this revision.Jan 19 2022, 2:40 PM

ardumont accepted this revision.Jan 19 2022, 4:49 PM

This revision is now accepted and ready to land.Jan 19 2022, 4:49 PM

Closed by commit rDLDSVN11740ebc2993: replay: Prevent removal of external paths overlapping versioned ones (authored by anlambert). · Explain WhyJan 19 2022, 4:52 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDSVN11740ebc2993: replay: Prevent removal of external paths overlapping versioned ones.