Page MenuHomeSoftware Heritage

Add support for env var substitution in statsd tags from STATSD_TAGS
ClosedPublic

Authored by douardda on Jan 13 2022, 3:47 PM.

Details

Summary

allow to configure statsd tags from environment variable (eg. add
the hostname as tag).

Event Timeline

Build is green

Patch application report for D6943 (id=25141)

Rebasing onto 4ff374f2f7...

Current branch diff-target is up to date.
Changes applied before test
commit 2e74fac1e912a056d5a6ddc06d9efa33411df3f1
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Jan 13 15:45:21 2022 +0100

    Add support for env var substitution in statsd tags from STATSD_TAGS
    
    allow to configure statsd tags from environment variable (eg. add
    the hostname as tag).

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/261/ for more details.

ardumont added a subscriber: ardumont.

lgtm

one suggestion inline.

swh/core/statsd.py
226

so as to try and avoid reading through the regexp ;)

This revision is now accepted and ready to land.Jan 14 2022, 9:50 AM

improve comment as suggested by ardumont

Build is green

Patch application report for D6943 (id=25160)

Rebasing onto 4ff374f2f7...

Current branch diff-target is up to date.
Changes applied before test
commit de9b0c9fb441bd4458827bb7500103d450536abe
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Jan 13 15:45:21 2022 +0100

    Add support for env var substitution in statsd tags from STATSD_TAGS
    
    allow to configure statsd tags from environment variable (eg. add
    the hostname as tag).

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/262/ for more details.