Differential D6931

Use sync-vagrant-conf wrapper script to deal with puppet manifest
ClosedPublic
Actions

Authored by ardumont on Jan 13 2022, 9:41 AM.

Details

Reviewers

vsellier

Group Reviewers

System administrators

Maniphest Tasks

T3833: Dedicate one admin host to centralize administration dbs

Commits

rSENV49b9efc5ea0d: Use sync-vagrant-conf wrapper script to deal with puppet manifest

Summary

Instead of using 1. prepare-vagrant-conf then 2. watch-vagrant-conf.
Let sync* do everything delegating to each its job.

Related to T3833

Test Plan

Actually use it does the right thing.
If the /tmp/puppet is not there, it calls prepare-vagrant-conf first.
(otherwise skips it)
Then calls the watch-vagrant-conf.

Diff Detail

Repository

rSENV Puppet Environment

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont requested review of this revision.Jan 13 2022, 9:41 AM

ardumont created this revision.

Harbormaster completed remote builds in B25988: Diff 25114.Jan 13 2022, 9:42 AM

ardumont added a reviewer: System administration.Jan 13 2022, 9:54 AM

ardumont edited reviewers, added: System administrators; removed: System administration.

LGTM thanks

vsellier accepted this revision.Jan 13 2022, 10:47 AM

This revision is now accepted and ready to land.Jan 13 2022, 10:47 AM

Closed by commit rSENV49b9efc5ea0d: Use sync-vagrant-conf wrapper script to deal with puppet manifest (authored by ardumont). · Explain WhyJan 13 2022, 10:52 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rSENV49b9efc5ea0d: Use sync-vagrant-conf wrapper script to deal with puppet manifest.

Revision Contents
Changeset List

Path

Size

bin/

sync-vagrant-conf

16 lines

Diff 25119

View Options

Use sync-vagrant-conf wrapper script to deal with puppet manifestClosedPublicActions