ra: Remove no-op method in DirEditor
ClosedPublic
Actions

Authored by anlambert on Jan 5 2022, 2:52 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDSVNd614911abfba: ra: Remove no-op method in DirEditor

Summary

The update_checksum method does nothing so better removing it.

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jan 5 2022, 2:52 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 5 2022, 2:52 PM

Build is green

Patch application report for D6881 (id=24948)

Rebasing onto 196c9d596b...

Current branch diff-target is up to date.

Changes applied before test

commit d614911abfbab5c1c6e4a0d704dcc4fb000be2e9
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Jan 5 14:51:38 2022 +0100

    ra: Remove no-op method in DirEditor
    
    The update_checksum method does nothing so better removing it.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/219/ for more details.

Harbormaster completed remote builds in B25819: Diff 24948.Jan 5 2022, 2:53 PM

anlambert requested review of this revision.Jan 5 2022, 2:53 PM

Thanks.

I guess it has something to do with your class merge last month or so (on that module).
That's no longer useful so yeah, let's drop it.

This revision is now accepted and ready to land.Jan 5 2022, 3:20 PM

In D6881#178901, @ardumont wrote:

Thanks.

I guess it has something to do with your class merge last month or so (on that module).
That's no longer useful so yeah, let's drop it.

Yes, I think it is a remain from the past but indeed I forgot to remove it when I merged the classes.

Closed by commit rDLDSVNd614911abfba: ra: Remove no-op method in DirEditor (authored by anlambert). · Explain WhyJan 5 2022, 4:10 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDSVNd614911abfba: ra: Remove no-op method in DirEditor.