Differential D6880

svn: Simplify swh_hash_data_at_revision method
ClosedPublic
Actions

Authored by anlambert on Jan 5 2022, 2:48 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDSVN27df073594f7: svn: Simplify swh_hash_data_at_revision method

Summary

Prefer to return values instead of yielding them as that method
does not match the iterator concept.

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jan 5 2022, 2:48 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 5 2022, 2:48 PM

Build is green

Patch application report for D6880 (id=24947)

Rebasing onto 196c9d596b...

Current branch diff-target is up to date.

Changes applied before test

commit aa22588b187888c0944b5e2f5a1a1075376bbc33
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Jan 5 14:47:11 2022 +0100

    svn: Simplify swh_hash_data_at_revision method
    
    Prefer to return values instead of yielding them as that method
    does not match the iterator concept.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/218/ for more details.

Harbormaster completed remote builds in B25818: Diff 24947.Jan 5 2022, 2:49 PM

anlambert requested review of this revision.Jan 5 2022, 2:49 PM

ardumont accepted this revision.Jan 5 2022, 3:18 PM

This revision is now accepted and ready to land.Jan 5 2022, 3:18 PM

rebase

Build is green

Patch application report for D6880 (id=24951)

Rebasing onto d614911abf...

Current branch diff-target is up to date.

Changes applied before test

commit 27df073594f731a6e111dcf5598846770c506e5f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Jan 5 14:47:11 2022 +0100

    svn: Simplify swh_hash_data_at_revision method
    
    Prefer to return values instead of yielding them as that method
    does not match the iterator concept.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/220/ for more details.

Harbormaster completed remote builds in B25822: Diff 24951.Jan 5 2022, 4:12 PM

Closed by commit rDLDSVN27df073594f7: svn: Simplify swh_hash_data_at_revision method (authored by anlambert). · Explain WhyJan 5 2022, 4:15 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDSVN27df073594f7: svn: Simplify swh_hash_data_at_revision method.