Page MenuHomeSoftware Heritage
Differential D688

SWHStatelessLoader: Pass config parameter to base class instead of None
ClosedPublic
Actions

Authored by anlambert on Nov 21 2018, 3:28 PM.

Details

Reviewers
ardumont
Commits
rDLDBASE27b156914e1b: SWHStatelessLoader: Pass config parameter to base class instead of None
Summary

Any reasons None was passed instead of the provided parameter ?

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Nov 21 2018, 3:28 PM
anlambert edited the summary of this revision. (Show Details)Nov 21 2018, 3:29 PM
swh-public-ci added a subscriber: swh-public-ci.Nov 21 2018, 3:32 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/22/ for more details.

Harbormaster completed remote builds in B2492: Diff 2154.Nov 21 2018, 3:32 PM
ardumont accepted this revision.Nov 21 2018, 3:43 PM

No reason comes to mind.
Knowing me, having such a strange behavior would have been commented upon.
So feels like a bug to me.

Thanks.

This revision is now accepted and ready to land.Nov 21 2018, 3:43 PM
Closed by commit rDLDBASE27b156914e1b: SWHStatelessLoader: Pass config parameter to base class instead of None (authored by anlambert). · Explain WhyNov 21 2018, 3:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
loader/
core/
2 lines

Diff 2162

View Options

swh/loader/core/loader.py

Loading...
About · Developer information · Legal