Differential D6859

Pin mypy and drop type annotations which makes mypy unhappy
ClosedPublic
Actions

Authored by ardumont on Dec 16 2021, 4:19 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Maniphest Tasks

T3812: Fix builds broken by mypy 0.920

Commits

rDSTOf09a54d4f523: Pin mypy and drop type annotations which makes mypy unhappy

Summary

This also drops:

spurious copyright headers to those files if present.
fix a type issue revealed by the new mypy

Ensure the jenkins' build is fine.

Related to T3812

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 16 2021, 4:19 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 16 2021, 4:19 PM

Build is green

Patch application report for D6859 (id=24854)

Rebasing onto c40ceb329f...

Current branch diff-target is up to date.

Changes applied before test

commit f09a54d4f523f465467115d6c7d584975817b93f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Dec 16 16:18:36 2021 +0100

    Pin mypy and drop type annotations which makes mypy unhappy
    
    This also drops:
    - spurious copyright headers to those files if present.
    - fix a type issue revealed by the new mypy
    
    Related to T3812

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1512/ for more details.

Harbormaster completed remote builds in B25719: Diff 24854.Dec 16 2021, 4:26 PM

ardumont requested review of this revision.Dec 16 2021, 4:26 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 16 2021, 4:38 PM

Closed by commit rDSTOf09a54d4f523: Pin mypy and drop type annotations which makes mypy unhappy (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTOf09a54d4f523: Pin mypy and drop type annotations which makes mypy unhappy.