Page MenuHomeSoftware Heritage

Pin mypy and drop type annotations which makes mypy unhappy
ClosedPublic

Authored by ardumont on Dec 16 2021, 2:22 PM.

Details

Summary

Related to T3812

Test Plan

tox (and especially mypy should still be happy)

Diff Detail

Repository
rDLDCVS CVS Loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25679
Build 40147: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 40146: arc lint + arc unit

Event Timeline

Build has FAILED

Patch application report for D6853 (id=24837)

Rebasing onto f191158dc4...

Current branch diff-target is up to date.
Changes applied before test
commit a5421c48035f70d236b68f6387e7a49c0b38eca1
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Dec 16 14:20:48 2021 +0100

    Drop type annotations which makes mypy unhappy
    
    Related to T3812

Link to build: https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/86/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/86/console

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 16 2021, 2:23 PM
Harbormaster failed remote builds in B25679: Diff 24837!

Drop now wrong version restriction

Build is green

Patch application report for D6853 (id=24838)

Rebasing onto f191158dc4...

Current branch diff-target is up to date.
Changes applied before test
commit 1328f5eefb2a1a8449b47989541984a2ec9395d8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Dec 16 14:20:48 2021 +0100

    Drop type annotations which makes mypy unhappy
    
    Related to T3812

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/87/ for more details.

ardumont retitled this revision from Drop type annotations which makes mypy unhappy to Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 2:30 PM
  • Pin mypy as well
  • rework and sync commit message and diff description

Build is green

Patch application report for D6853 (id=24839)

Rebasing onto f191158dc4...

Current branch diff-target is up to date.
Changes applied before test
commit cbde981229dce0877123b7e27a44daeba67b9386
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Dec 16 14:20:48 2021 +0100

    Pin mypy and drop type annotations which makes mypy unhappy
    
    This also drops spurious copyright headers to those files if present.
    
    Related to T3812

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/88/ for more details.

This revision is now accepted and ready to land.Dec 16 2021, 2:34 PM