Differential D6853

Pin mypy and drop type annotations which makes mypy unhappy
ClosedPublic
Actions

Authored by ardumont on Dec 16 2021, 2:22 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Maniphest Tasks

T3812: Fix builds broken by mypy 0.920

Commits

rDLDCVScbde981229dc: Pin mypy and drop type annotations which makes mypy unhappy

Summary

Related to T3812

Test Plan

tox (and especially mypy should still be happy)

Diff Detail

Repository

rDLDCVS CVS Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25679
Build 40147: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 40146: arc lint + arc unit

Event Timeline

ardumont created this revision.Dec 16 2021, 2:22 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 16 2021, 2:22 PM

Build has FAILED

Patch application report for D6853 (id=24837)

Rebasing onto f191158dc4...

Current branch diff-target is up to date.

Changes applied before test

commit a5421c48035f70d236b68f6387e7a49c0b38eca1
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Dec 16 14:20:48 2021 +0100

    Drop type annotations which makes mypy unhappy
    
    Related to T3812

Link to build: https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/86/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/86/console

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 16 2021, 2:23 PM

Harbormaster failed remote builds in B25679: Diff 24837!

Drop now wrong version restriction

Build is green

Patch application report for D6853 (id=24838)

Rebasing onto f191158dc4...

Current branch diff-target is up to date.

Changes applied before test

commit 1328f5eefb2a1a8449b47989541984a2ec9395d8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Dec 16 14:20:48 2021 +0100

    Drop type annotations which makes mypy unhappy
    
    Related to T3812

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/87/ for more details.

Harbormaster completed remote builds in B25680: Diff 24838.Dec 16 2021, 2:26 PM

ardumont requested review of this revision.Dec 16 2021, 2:26 PM

ardumont retitled this revision from Drop type annotations which makes mypy unhappy to Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 2:30 PM

Pin mypy as well
rework and sync commit message and diff description

Build is green

Patch application report for D6853 (id=24839)

Rebasing onto f191158dc4...

Current branch diff-target is up to date.

Changes applied before test

commit cbde981229dce0877123b7e27a44daeba67b9386
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Dec 16 14:20:48 2021 +0100

    Pin mypy and drop type annotations which makes mypy unhappy
    
    This also drops spurious copyright headers to those files if present.
    
    Related to T3812

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/88/ for more details.

Harbormaster completed remote builds in B25681: Diff 24839.Dec 16 2021, 2:33 PM

olasd accepted this revision.Dec 16 2021, 2:34 PM

This revision is now accepted and ready to land.Dec 16 2021, 2:34 PM

ardumont mentioned this in D6854: Drop unnecessary type annotation to fix mypy 0.920 issue.Dec 16 2021, 2:54 PM

Closed by commit rDLDCVScbde981229dc: Pin mypy and drop type annotations which makes mypy unhappy (authored by ardumont). · Explain WhyDec 16 2021, 3:00 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDCVScbde981229dc: Pin mypy and drop type annotations which makes mypy unhappy.

ardumont mentioned this in D6806: Fix typing which fails the build.Dec 16 2021, 4:52 PM