Page MenuHomeSoftware Heritage
Differential D6846

Clean up code after frontier redefinition from previous commit
ClosedPublic
Actions

Authored by aeviso on Dec 15 2021, 4:45 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDPROV1926b9d575fb: Clean up code after frontier redefinition from previous commit
Summary

The known flag from IsochroneNode is no longer being used, and
maxdate calculation can thus be simplified. Isochrone graph related
tests are updated as well to reflect the changes.

Diff Detail

Event Timeline

aeviso created this revision.Dec 15 2021, 4:45 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 15 2021, 4:45 PM
swh-public-ci added a comment.Dec 15 2021, 4:50 PM

Build is green

Patch application report for D6846 (id=24808)

Rebasing onto eb48f7960d...

Current branch diff-target is up to date.
Changes applied before test
commit 960770e7694db2640c2e74270f27e740647b051a
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Dec 15 16:43:02 2021 +0100

    Clean up code after frontier redefinition from previous commit
    
    The `known` flag from `IsochroneNode` is no longer being used and
    `maxdate` calculation can thus be simplified, Isochrne graph related
    tests are updated as well to reflect the changes.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/545/ for more details.

Harbormaster completed remote builds in B25656: Diff 24808.Dec 15 2021, 4:50 PM
aeviso requested review of this revision.Dec 15 2021, 4:50 PM
aeviso edited the summary of this revision. (Show Details)Dec 16 2021, 11:38 AM
aeviso edited the summary of this revision. (Show Details)
aeviso updated this revision to Diff 24833.Dec 16 2021, 11:39 AM

rebase

swh-public-ci added a comment.Dec 16 2021, 11:40 AM

Build has FAILED

Patch application report for D6846 (id=24833)

Rebasing onto eb48f7960d...

Current branch diff-target is up to date.
Changes applied before test
commit 294fcff0812f0453dc1e99895c982fb6db5a4179
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Dec 15 16:43:02 2021 +0100

    Clean up code after frontier redefinition from previous commit
    
    The `known` flag from `IsochroneNode` is no longer being used, and
    `maxdate` calculation can thus be simplified. Isochrone graph related
    tests are updated as well to reflect the changes.

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/546/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/546/console

Harbormaster failed remote builds in B25676: Diff 24833!Dec 16 2021, 11:40 AM
swh-public-ci added a comment.Dec 16 2021, 11:43 AM

Build has FAILED

Patch application report for D6846 (id=24833)

Rebasing onto eb48f7960d...

Current branch diff-target is up to date.
Changes applied before test
commit 294fcff0812f0453dc1e99895c982fb6db5a4179
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Dec 15 16:43:02 2021 +0100

    Clean up code after frontier redefinition from previous commit
    
    The `known` flag from `IsochroneNode` is no longer being used, and
    `maxdate` calculation can thus be simplified. Isochrone graph related
    tests are updated as well to reflect the changes.

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/547/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/547/console

aeviso added a parent revision: D6854: Drop unnecessary type annotation to fix mypy 0.920 issue.Dec 16 2021, 2:35 PM
aeviso updated this revision to Diff 24841.Dec 16 2021, 2:36 PM

rebase

swh-public-ci added a comment.Dec 16 2021, 2:42 PM

Build is green

Patch application report for D6846 (id=24841)

Could not rebase; Attempt merge onto eb48f7960d...

Updating eb48f79..6524bf0
Fast-forward
 swh/__init__.py                                    |  3 +--
 swh/provenance/graph.py                            | 27 +++----------------
 swh/provenance/revision.py                         |  4 +--
 .../tests/data/graphs_cmdbts2_lower_1.yaml         | 31 ----------------------
 .../tests/data/graphs_cmdbts2_lower_2.yaml         | 31 ----------------------
 .../tests/data/graphs_cmdbts2_upper_1.yaml         | 27 -------------------
 .../tests/data/graphs_cmdbts2_upper_2.yaml         | 26 ------------------
 .../tests/data/graphs_out-of-order_lower_1.yaml    | 19 +++----------
 swh/provenance/tests/test_isochrone_graph.py       |  1 -
 9 files changed, 10 insertions(+), 159 deletions(-)
Changes applied before test
commit 6524bf0140453eebbbe2c5f3cf2f89e0e4c642f5
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Dec 15 16:43:02 2021 +0100

    Clean up code after frontier redefinition from previous commit
    
    The `known` flag from `IsochroneNode` is no longer being used, and
    `maxdate` calculation can thus be simplified. Isochrone graph related
    tests are updated as well to reflect the changes.

commit 83d45b7c2be2f81e306693001be8f0dc31fca88a
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Dec 16 14:31:18 2021 +0100

    Drop unnecessary type annotation to fix mypy 0.920 issue

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/549/ for more details.

Harbormaster completed remote builds in B25683: Diff 24841.Dec 16 2021, 2:42 PM
aeviso updated this revision to Diff 24843.Dec 16 2021, 2:58 PM

rebase

swh-public-ci added a comment.Dec 16 2021, 3:04 PM

Build is green

Patch application report for D6846 (id=24843)

Could not rebase; Attempt merge onto eb48f7960d...

Updating eb48f79..3da57b2
Fast-forward
 swh/__init__.py                                    |  3 +--
 swh/provenance/graph.py                            | 27 +++----------------
 swh/provenance/revision.py                         |  4 +--
 .../tests/data/graphs_cmdbts2_lower_1.yaml         | 31 ----------------------
 .../tests/data/graphs_cmdbts2_lower_2.yaml         | 31 ----------------------
 .../tests/data/graphs_cmdbts2_upper_1.yaml         | 27 -------------------
 .../tests/data/graphs_cmdbts2_upper_2.yaml         | 26 ------------------
 .../tests/data/graphs_out-of-order_lower_1.yaml    | 19 +++----------
 swh/provenance/tests/test_isochrone_graph.py       |  1 -
 tox.ini                                            |  2 +-
 10 files changed, 11 insertions(+), 160 deletions(-)
Changes applied before test
commit 3da57b271d046d8fa9c0dc589ae9d5ca3c164618
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Dec 15 16:43:02 2021 +0100

    Clean up code after frontier redefinition from previous commit
    
    The `known` flag from `IsochroneNode` is no longer being used, and
    `maxdate` calculation can thus be simplified. Isochrone graph related
    tests are updated as well to reflect the changes.

commit bef0ab385dfa94a41f8dd256817a633d60b11605
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Dec 16 14:31:18 2021 +0100

    Drop unnecessary type annotation to fix mypy 0.920 issue

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/551/ for more details.

Harbormaster completed remote builds in B25685: Diff 24843.Dec 16 2021, 3:04 PM
aeviso removed a parent revision: D6854: Drop unnecessary type annotation to fix mypy 0.920 issue.Dec 16 2021, 3:06 PM
aeviso added a child revision: D6862: Clean up history graph implementation.Dec 17 2021, 12:32 PM
aeviso updated this revision to Diff 24873.Dec 20 2021, 12:23 PM

rebase

aeviso added a child revision: D6864: Move date calculation for invalidated frontiers to the revision processing module.Dec 20 2021, 12:24 PM
aeviso removed a child revision: D6862: Clean up history graph implementation.Dec 20 2021, 12:25 PM
swh-public-ci added a comment.Dec 20 2021, 12:30 PM

Build is green

Patch application report for D6846 (id=24873)

Rebasing onto bef0ab385d...

Current branch diff-target is up to date.
Changes applied before test
commit 1926b9d575fb7c406f02fea52f03cb9ab0ef5b70
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Dec 15 16:43:02 2021 +0100

    Clean up code after frontier redefinition from previous commit
    
    The `known` flag from `IsochroneNode` is no longer being used, and
    `maxdate` calculation can thus be simplified. Isochrone graph related
    tests are updated as well to reflect the changes.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/553/ for more details.

Harbormaster completed remote builds in B25739: Diff 24873.Dec 20 2021, 12:30 PM
olasd accepted this revision.Dec 21 2021, 3:50 PM
olasd added a subscriber: olasd.

ACK, makes sense.

This revision is now accepted and ready to land.Dec 21 2021, 3:50 PM
Closed by commit rDPROV1926b9d575fb: Clean up code after frontier redefinition from previous commit (authored by aeviso). · Explain WhyDec 21 2021, 3:52 PM
This revision was automatically updated to reflect the committed changes.
aeviso added a commit: rDPROV1926b9d575fb: Clean up code after frontier redefinition from previous commit.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
provenance/
27 lines98%
Loading...
4 lines95%
Loading...
tests/
data/
31 lines--
31 lines--
27 lines--
26 lines--
19 lines--
1 line100%
Loading...

Diff 24808

View Options

swh/provenance/graph.py

Loading...
View Options

swh/provenance/revision.py

Loading...
View Options

swh/provenance/tests/data/graphs_cmdbts2_lower_1.yaml

Loading...
View Options

swh/provenance/tests/data/graphs_cmdbts2_lower_2.yaml

Loading...
View Options

swh/provenance/tests/data/graphs_cmdbts2_upper_1.yaml

Loading...
View Options

swh/provenance/tests/data/graphs_cmdbts2_upper_2.yaml

Loading...
View Options

swh/provenance/tests/data/graphs_out-of-order_lower_1.yaml

Loading...
View Options

swh/provenance/tests/test_isochrone_graph.py

Loading...
About · Developer information · Legal