Differential D6810

add libcmph-dev so that swh-perfecthash can build and install
ClosedPublic
Actions

Authored by dachary on Dec 9 2021, 11:46 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDENV50295a1c291e: add libcmph-dev so that swh-perfecthash can build and install

Summary

Related to: T3783

Diff Detail

Repository

rDENV Development environment

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dachary created this revision.Dec 9 2021, 11:46 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 9 2021, 11:46 AM

dachary requested review of this revision.Dec 9 2021, 11:46 AM

Harbormaster completed remote builds in B25536: Diff 24682.Dec 9 2021, 11:46 AM

Thanks; please add it to https://docs.softwareheritage.org/devel/developer-setup.html#install-required-dependencies as well

This revision is now accepted and ready to land.Dec 9 2021, 11:50 AM

olasd added a subscriber: olasd.Dec 9 2021, 11:52 AM

olasd added inline comments.

docker/Dockerfile
16–17	I think these are kinda sorted alphabetically (not that it matters much)

sort

Harbormaster completed remote builds in B25538: Diff 24684.Dec 9 2021, 2:47 PM

dachary marked an inline comment as done.Dec 9 2021, 2:47 PM

dachary added inline comments.

docker/Dockerfile
16–17	Done!

Closed by commit rDENV50295a1c291e: add libcmph-dev so that swh-perfecthash can build and install (authored by dachary). · Explain WhyDec 9 2021, 2:48 PM

This revision was automatically updated to reflect the committed changes.

dachary marked an inline comment as done.

dachary added a commit: rDENV50295a1c291e: add libcmph-dev so that swh-perfecthash can build and install.

Thanks for the quick review :-)

Revision Contents
Changeset List

Path

Size

docker/

Dockerfile

1 line

Diff 24685

View Options

add libcmph-dev so that swh-perfecthash can build and installClosedPublicActions