Page MenuHomeSoftware Heritage
Differential D679

Increase test coverage for stat_counters + fix its bugs.
ClosedPublic
Actions

Authored by vlorentz on Nov 20 2018, 3:21 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDSTOCdd62eae66146: Increase test coverage for stat_counters + fix its bugs.
R65:dd62eae66146: Increase test coverage for stat_counters + fix its bugs.
rDSTOdd62eae66146: Increase test coverage for stat_counters + fix its bugs.

Diff Detail

Repository
rDSTO Storage manager
Branch
fix-inmem-stat_counters
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2510
Build 3105: tox-on-jenkinsJenkins
Build 3104: arc lint + arc unit

Event Timeline

vlorentz created this revision.Nov 20 2018, 3:21 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 20 2018, 3:21 PM
swh-public-ci added a subscriber: swh-public-ci.Nov 20 2018, 4:30 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/93/ for more details.

Harbormaster completed remote builds in B2461: Diff 2140.Nov 20 2018, 4:30 PM
anlambert accepted this revision.Nov 21 2018, 5:03 PM
anlambert added a subscriber: anlambert.

Apart the removal of no more used stat counters keys, LGTM.

swh/storage/in_memory.py
902

Based on what I see in the 'object_counts' table in the production database, the keys directory_entry_dir, directory_entry_file, directory_entry_rev and revision_history are no more supported, so you can safely remove them.
I should also reflect that in the web api /stat/counters endpoint documentation.

I also noticed that the person and origin_visit values are still equal to 0 after loading a git repository
using the in-memory storage as a backend. In order to reflect the storage in production, those should be
handled too but that out of scope for that diff.

This revision is now accepted and ready to land.Nov 21 2018, 5:03 PM
vlorentz updated this revision to Diff 2170.Nov 21 2018, 5:07 PM
  • Remove unused counters.
Harbormaster failed remote builds in B2509: Diff 2170!Nov 21 2018, 5:08 PM
swh-public-ci added a comment.Nov 21 2018, 5:08 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/102/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/102/console

vlorentz updated this revision to Diff 2171.Nov 21 2018, 5:09 PM
  • Remove directory_entry_dir.
Closed by commit rDSTOdd62eae66146: Increase test coverage for stat_counters + fix its bugs. (authored by vlorentz). · Explain WhyNov 21 2018, 5:09 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B2510: Diff 2171!Nov 21 2018, 5:10 PM
swh-public-ci added a comment.Nov 21 2018, 5:10 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/103/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/103/console

vlorentz marked an inline comment as done.Nov 21 2018, 5:11 PM
vlorentz added inline comments.
swh/storage/in_memory.py
902

I also noticed that the person and origin_visit values are still equal to 0 after loading a git repository
using the in-memory storage as a backend. In order to reflect the storage in production, those should be
handled too but that out of scope for that diff.

-> T1377

Revision Contents
Changeset List

PathSize
swh/
storage/
10 lines
tests/
37 lines

Diff 2171

View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal