Page MenuHomeSoftware Heritage

Add tests for expected statsd reports during a content replay session
ClosedPublic

Authored by douardda on Dec 2 2021, 11:06 AM.

Details

Summary

Also include the revision:

Small code refactoring in test_cli

make '_fill_objstorage_and_kafka()' take the actual objstorage as
argument, instead of the dict of objstorages ("src", "dst"). The "dst"
objstorage is not used in the function, and it make the intent of this
later clearer.

Diff Detail

Repository
rDOBJSRPL Content replayer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6724 (id=24428)

Rebasing onto 720b7af2bf...

Current branch diff-target is up to date.
Changes applied before test
commit ef9d30c009d7e70226d53e52c3a382813e9e33d5
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Dec 1 17:28:56 2021 +0100

    Add tests for expected statsd reports during a content replay session

commit 002443567791de9ffef1a2b443eb7471d120bebe
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Nov 25 17:36:27 2021 +0100

    Small code refactoring in test_cli
    
    make '_fill_objstorage_and_kafka()' take the actual objstorage as
    argument, instead of the dict of objstorages ("src", "dst"). The "dst"
    objstorage is not used in the function, and it make the intent of this
    later clearer.

See https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/19/ for more details.

olasd added a subscriber: olasd.

Thanks!

swh/objstorage/replayer/tests/test_statsd.py
25 ↗(On Diff #24428)

typo (statds->statsd)

This revision is now accepted and ready to land.Dec 2 2021, 11:13 AM

typo and small improvement in the test

Build is green

Patch application report for D6724 (id=24433)

Rebasing onto 720b7af2bf...

Current branch diff-target is up to date.
Changes applied before test
commit 1d8ea80c7d01847dba16343508b74a037a1da864
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Dec 1 17:28:56 2021 +0100

    Add tests for expected statsd reports during a content replay session

commit 002443567791de9ffef1a2b443eb7471d120bebe
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Nov 25 17:36:27 2021 +0100

    Small code refactoring in test_cli
    
    make '_fill_objstorage_and_kafka()' take the actual objstorage as
    argument, instead of the dict of objstorages ("src", "dst"). The "dst"
    objstorage is not used in the function, and it make the intent of this
    later clearer.

See https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/21/ for more details.