Page MenuHomeSoftware Heritage
Differential D6713

Unify parameter order between provenance and archive objects across the module
ClosedPublic
Actions

Authored by aeviso on Dec 1 2021, 3:54 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDPROV052e25da505c: Unify parameter order between provenance and archive objects across the module
Summary

Depends on D6712.

Diff Detail

Event Timeline

aeviso created this revision.Dec 1 2021, 3:54 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 1 2021, 3:54 PM
aeviso added a child revision: D6714: Add support to flatten directories in the isochrone frontiers separately.Dec 1 2021, 3:55 PM
aeviso retitled this revision from Unify parameter order between provenance and archive objects along the module to Unify parameter order between provenance and archive objects across the module.Dec 1 2021, 3:58 PM
aeviso updated this revision to Diff 24396.Dec 1 2021, 3:59 PM

rebase

swh-public-ci added a comment.Dec 1 2021, 4:07 PM

Build is green

Patch application report for D6713 (id=24393)

Could not rebase; Attempt merge onto 6306b44896...

Updating 6306b44..ae96d01
Fast-forward
 sql/upgrades/002.sql                               |  17 +++
 swh/provenance/api/serializers.py                  |   5 +-
 swh/provenance/api/server.py                       |  44 +++++--
 swh/provenance/graph.py                            |   4 +-
 swh/provenance/interface.py                        |  42 ++++---
 swh/provenance/mongo/backend.py                    |  48 ++++----
 swh/provenance/origin.py                           |   2 +-
 swh/provenance/postgresql/provenance.py            | 137 ++++++++++++---------
 swh/provenance/provenance.py                       |  55 +++++++--
 swh/provenance/revision.py                         |  10 +-
 swh/provenance/sql/30-schema.sql                   |  71 +++++------
 swh/provenance/tests/test_conflict_resolution.py   |  43 ++++---
 swh/provenance/tests/test_history_graph.py         |   2 +-
 swh/provenance/tests/test_isochrone_graph.py       |   2 +-
 swh/provenance/tests/test_provenance_storage.py    |  39 +++---
 .../tests/test_revision_content_layer.py           |   4 +-
 swh/provenance/tests/test_routing_keys.py          |  66 ++++++++++
 swh/provenance/tests/test_split_ranges.py          | 137 +++++++++++++++++++++
 18 files changed, 516 insertions(+), 212 deletions(-)
 create mode 100644 sql/upgrades/002.sql
 create mode 100644 swh/provenance/tests/test_routing_keys.py
 create mode 100644 swh/provenance/tests/test_split_ranges.py
Changes applied before test
commit ae96d01f62bc0f4319af6c79a1f1989aa795cc1b
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Dec 1 15:00:28 2021 +0100

    Unify parameter order between provenance and archive objects along the module

commit 08d780fe95174257f6d69b5bd4a04700b3c83671
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Dec 1 13:21:33 2021 +0100

    Add explicit flag for flattenned directories to `ProvenanceStorageInterdace`
    
    Both contents and directories should always have an associated date in
    the storage. Flattening of a direcory is know explicitly acknowledged
    by setting the newly added flag.

commit ea4a856c71d00bfd315890a317af38351d5f7ebb
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Nov 29 14:42:11 2021 +0100

    Add test for range splitting function

commit 247574bec84d471a6e78721d02b115b6017d2f9d
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Nov 29 14:41:28 2021 +0100

    Add test for routing key calculation

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/512/ for more details.

Harbormaster completed remote builds in B25270: Diff 24393.Dec 1 2021, 4:07 PM
swh-public-ci added a comment.Dec 1 2021, 4:12 PM

Build is green

Patch application report for D6713 (id=24396)

Could not rebase; Attempt merge onto 6306b44896...

Updating 6306b44..d3345b8
Fast-forward
 sql/upgrades/002.sql                               |  17 +++
 swh/provenance/api/serializers.py                  |   5 +-
 swh/provenance/api/server.py                       |  44 +++++--
 swh/provenance/graph.py                            |   4 +-
 swh/provenance/interface.py                        |  42 ++++---
 swh/provenance/mongo/backend.py                    |  48 ++++----
 swh/provenance/origin.py                           |   2 +-
 swh/provenance/postgresql/provenance.py            | 137 ++++++++++++---------
 swh/provenance/provenance.py                       |  55 +++++++--
 swh/provenance/revision.py                         |  10 +-
 swh/provenance/sql/30-schema.sql                   |  71 +++++------
 swh/provenance/tests/test_conflict_resolution.py   |  43 ++++---
 swh/provenance/tests/test_history_graph.py         |   2 +-
 swh/provenance/tests/test_isochrone_graph.py       |   2 +-
 swh/provenance/tests/test_provenance_storage.py    |  39 +++---
 .../tests/test_revision_content_layer.py           |   4 +-
 swh/provenance/tests/test_routing_keys.py          |  66 ++++++++++
 swh/provenance/tests/test_split_ranges.py          | 137 +++++++++++++++++++++
 18 files changed, 516 insertions(+), 212 deletions(-)
 create mode 100644 sql/upgrades/002.sql
 create mode 100644 swh/provenance/tests/test_routing_keys.py
 create mode 100644 swh/provenance/tests/test_split_ranges.py
Changes applied before test
commit d3345b815ecca205ac425b5e20869938cecf6182
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Dec 1 15:00:28 2021 +0100

    Unify parameter order between provenance and archive objects across the module

commit c0f0fcbb41d331aab8ceb25e6729562501222f78
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Dec 1 13:21:33 2021 +0100

    Add explicit flag for flattenned directories to `ProvenanceStorageInterface`
    
    Both contents and directories should always have an associated date in
    the storage. Flattening of a direcory is know explicitly acknowledged
    by setting the newly added flag.

commit ea4a856c71d00bfd315890a317af38351d5f7ebb
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Nov 29 14:42:11 2021 +0100

    Add test for range splitting function

commit 247574bec84d471a6e78721d02b115b6017d2f9d
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Nov 29 14:41:28 2021 +0100

    Add test for routing key calculation

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/515/ for more details.

Harbormaster completed remote builds in B25273: Diff 24396.Dec 1 2021, 4:12 PM
aeviso requested review of this revision.Dec 1 2021, 4:12 PM
vlorentz accepted this revision.Dec 1 2021, 5:16 PM
This revision is now accepted and ready to land.Dec 1 2021, 5:16 PM
aeviso updated this revision to Diff 24417.Dec 2 2021, 10:36 AM

rebase

swh-public-ci added a comment.Dec 2 2021, 10:45 AM

Build is green

Patch application report for D6713 (id=24417)

Could not rebase; Attempt merge onto 247574bec8...

Updating 247574b..812df71
Fast-forward
 sql/upgrades/002.sql                               |  17 +++
 swh/provenance/api/serializers.py                  |   5 +-
 swh/provenance/api/server.py                       |  44 +++++--
 swh/provenance/graph.py                            |   4 +-
 swh/provenance/interface.py                        |  42 ++++---
 swh/provenance/mongo/backend.py                    |  48 ++++----
 swh/provenance/origin.py                           |   2 +-
 swh/provenance/postgresql/provenance.py            | 137 ++++++++++++---------
 swh/provenance/provenance.py                       |  55 +++++++--
 swh/provenance/revision.py                         |  10 +-
 swh/provenance/sql/30-schema.sql                   |  71 +++++------
 swh/provenance/tests/test_conflict_resolution.py   |  43 ++++---
 swh/provenance/tests/test_history_graph.py         |   2 +-
 swh/provenance/tests/test_isochrone_graph.py       |   2 +-
 swh/provenance/tests/test_provenance_storage.py    |  39 +++---
 .../tests/test_revision_content_layer.py           |   4 +-
 swh/provenance/tests/test_split_ranges.py          | 137 +++++++++++++++++++++
 17 files changed, 450 insertions(+), 212 deletions(-)
 create mode 100644 sql/upgrades/002.sql
 create mode 100644 swh/provenance/tests/test_split_ranges.py
Changes applied before test
commit 812df71d99daacb25d1df73522cb754b0842af83
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Dec 1 15:00:28 2021 +0100

    Unify parameter order between provenance and archive objects across the module

commit 765135807ee60342f0b9e62d584c5bd46fedb069
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Dec 1 13:21:33 2021 +0100

    Add explicit flag for flattenned directories to `ProvenanceStorageInterface`
    
    Both contents and directories should always have an associated date in
    the storage. Flattening of a direcory is know explicitly acknowledged
    by setting the newly added flag.

commit dd1d7aa233a69fa87b16a361b12ae255605c6899
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Nov 29 14:42:11 2021 +0100

    Add test for range splitting function

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/520/ for more details.

Harbormaster completed remote builds in B25294: Diff 24417.Dec 2 2021, 10:45 AM
aeviso updated this revision to Diff 24719.Dec 10 2021, 5:44 PM

rebase

swh-public-ci added a comment.Dec 10 2021, 5:47 PM

Build has FAILED

Patch application report for D6713 (id=24719)

Could not rebase; Attempt merge onto dd1d7aa233...

Updating dd1d7aa..052e25d
Fast-forward
 sql/upgrades/002.sql                               |  17 +++
 swh/provenance/api/serializers.py                  |   5 +-
 swh/provenance/api/server.py                       |  44 +++++--
 swh/provenance/graph.py                            |   4 +-
 swh/provenance/interface.py                        |  42 ++++---
 swh/provenance/mongo/backend.py                    |  48 ++++----
 swh/provenance/origin.py                           |   2 +-
 swh/provenance/postgresql/provenance.py            | 137 ++++++++++++---------
 swh/provenance/provenance.py                       |  57 +++++++--
 swh/provenance/revision.py                         |  10 +-
 swh/provenance/sql/30-schema.sql                   |  71 +++++------
 swh/provenance/tests/test_conflict_resolution.py   |  43 ++++---
 swh/provenance/tests/test_history_graph.py         |   2 +-
 swh/provenance/tests/test_isochrone_graph.py       |   2 +-
 swh/provenance/tests/test_provenance_storage.py    |  39 +++---
 .../tests/test_revision_content_layer.py           |   4 +-
 16 files changed, 314 insertions(+), 213 deletions(-)
 create mode 100644 sql/upgrades/002.sql
Changes applied before test
commit 052e25da505c77da90d1c54ce0ade775117422e4
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Dec 1 15:00:28 2021 +0100

    Unify parameter order between provenance and archive objects across the module

commit f4f48923e86ef0054642165bcb9ecf4387d70bb8
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Dec 1 13:21:33 2021 +0100

    Add explicit flag for flattenned directories to `ProvenanceStorageInterface`
    
    Both contents and directories should always have an associated date in the storage.
    Flattening of a directory is now explicitly acknowledged by setting the newly added
    flag. The idea is to allow to postpone the creation of flat models for directories
    in the isochrone frontier (the algorithm will be refactored in the commits to come).

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/536/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/536/console

Harbormaster failed remote builds in B25571: Diff 24719!Dec 10 2021, 5:47 PM
swh-public-ci added a comment.Dec 10 2021, 5:57 PM

Build is green

Patch application report for D6713 (id=24719)

Could not rebase; Attempt merge onto dd1d7aa233...

Updating dd1d7aa..052e25d
Fast-forward
 sql/upgrades/002.sql                               |  17 +++
 swh/provenance/api/serializers.py                  |   5 +-
 swh/provenance/api/server.py                       |  44 +++++--
 swh/provenance/graph.py                            |   4 +-
 swh/provenance/interface.py                        |  42 ++++---
 swh/provenance/mongo/backend.py                    |  48 ++++----
 swh/provenance/origin.py                           |   2 +-
 swh/provenance/postgresql/provenance.py            | 137 ++++++++++++---------
 swh/provenance/provenance.py                       |  57 +++++++--
 swh/provenance/revision.py                         |  10 +-
 swh/provenance/sql/30-schema.sql                   |  71 +++++------
 swh/provenance/tests/test_conflict_resolution.py   |  43 ++++---
 swh/provenance/tests/test_history_graph.py         |   2 +-
 swh/provenance/tests/test_isochrone_graph.py       |   2 +-
 swh/provenance/tests/test_provenance_storage.py    |  39 +++---
 .../tests/test_revision_content_layer.py           |   4 +-
 16 files changed, 314 insertions(+), 213 deletions(-)
 create mode 100644 sql/upgrades/002.sql
Changes applied before test
commit 052e25da505c77da90d1c54ce0ade775117422e4
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Dec 1 15:00:28 2021 +0100

    Unify parameter order between provenance and archive objects across the module

commit f4f48923e86ef0054642165bcb9ecf4387d70bb8
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Dec 1 13:21:33 2021 +0100

    Add explicit flag for flattenned directories to `ProvenanceStorageInterface`
    
    Both contents and directories should always have an associated date in the storage.
    Flattening of a directory is now explicitly acknowledged by setting the newly added
    flag. The idea is to allow to postpone the creation of flat models for directories
    in the isochrone frontier (the algorithm will be refactored in the commits to come).

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/542/ for more details.

Harbormaster completed remote builds in B25571: Diff 24719.Dec 10 2021, 5:57 PM
Closed by commit rDPROV052e25da505c: Unify parameter order between provenance and archive objects across the module (authored by aeviso). · Explain WhyDec 10 2021, 5:58 PM
This revision was automatically updated to reflect the committed changes.
aeviso added a commit: rDPROV052e25da505c: Unify parameter order between provenance and archive objects across the module.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
provenance/
4 lines98%
Loading...
2 lines97%
Loading...
10 lines94%
Loading...
tests/
2 lines100%
Loading...
2 lines100%
Loading...
2 lines97%
Loading...

Diff 24393

View Options

swh/provenance/graph.py

Loading...
View Options

swh/provenance/origin.py

Loading...
View Options

swh/provenance/revision.py

Loading...
View Options

swh/provenance/tests/test_history_graph.py

Loading...
View Options

swh/provenance/tests/test_isochrone_graph.py

Loading...
View Options

swh/provenance/tests/test_provenance_storage.py

Loading...
About · Developer information · Legal