Page MenuHomeSoftware Heritage

Stop writing swhid2node.bin maps
ClosedPublic

Authored by seirl on Nov 26 2021, 5:34 PM.

Details

Summary

This mapping is no longer needed since rDGRPH0b33cff0d228, so we stop writing
it to disk.

Diff Detail

Event Timeline

Build is green

Patch application report for D6699 (id=24334)

Rebasing onto 0b33cff0d2...

Current branch diff-target is up to date.
Changes applied before test
commit d0dbfda9a775f031f3e4e29169e537a7ad91d21e
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Fri Nov 26 17:32:45 2021 +0100

    Stop writing swhid2node.bin maps

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/142/ for more details.

seirl requested review of this revision.Nov 26 2021, 5:36 PM
douardda added a subscriber: douardda.

Looks overall ok to me, but I miss a few "why?" here:

  • the "why stop writing this file" should be in the commit message,
  • why the need for SortOutputHandler attributes to become final?
This revision is now accepted and ready to land.Nov 29 2021, 10:00 AM

why the need for SortOutputHandler attributes to become final?

No need, it's just a default warning when a field in a class can become final. I don't know how much of a good practice it is, maybe I could remove the warning.

This revision was automatically updated to reflect the committed changes.