Page MenuHomeSoftware Heritage
Differential D6672

Vagrantfile: Fix vagrant environment lookup for admin nodes
ClosedPublic
Actions

Authored by ardumont on Nov 23 2021, 3:43 PM.

Details

Reviewers
vsellier
Group Reviewers
System administration
Maniphest Tasks
T3749: Migrate hedgedoc stack to bullseye
Commits
rSENVccfffc7dca46: Vagrantfile: Fix vagrant environment lookup for admin nodes
Summary

The vagrant up instruction currently fails in trying to find a file which does not
exist. This is due to an environment declaration and branch mismatch.

This commit fixes it.

Related to P1220
Related to T3749

Test Plan

One of each environment's machine has been built to ensure everything is fine:

|-----------------------------+-------------+---------------+------------|
| Command                     | environment | without patch | with patch |
|-----------------------------+-------------+---------------+------------|
| `vagrant up admin-bardo`    | admin       | KO            | OK         |
| `vagrant up logstash` OK    | production  | OK            | OK         |
| `vagrant up staging-webapp` | staging     | OK            | OK         |
|-----------------------------+-------------+---------------+------------|

Diff Detail

Repository
rSENV Puppet Environment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont requested review of this revision.Nov 23 2021, 3:43 PM
ardumont created this revision.
Harbormaster completed remote builds in B25119: Diff 24243.Nov 23 2021, 3:43 PM
ardumont edited the test plan for this revision. (Show Details)Nov 23 2021, 3:47 PM
ardumont added a reviewer: System administration.
ardumont updated this revision to Diff 24248.Nov 23 2021, 3:52 PM
ardumont edited the test plan for this revision. (Show Details)

Rename variable to something more sensible

Harbormaster completed remote builds in B25124: Diff 24248.Nov 23 2021, 3:52 PM
ardumont edited the summary of this revision. (Show Details)Nov 23 2021, 3:57 PM
ardumont added a task: T3749: Migrate hedgedoc stack to bullseye.
ardumont edited the test plan for this revision. (Show Details)Nov 23 2021, 3:59 PM
vsellier accepted this revision.Nov 23 2021, 5:23 PM
vsellier added a subscriber: vsellier.

thanks for having fixed this

This revision is now accepted and ready to land.Nov 23 2021, 5:23 PM
Closed by commit rSENVccfffc7dca46: Vagrantfile: Fix vagrant environment lookup for admin nodes (authored by ardumont). · Explain WhyNov 23 2021, 5:39 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rSENVccfffc7dca46: Vagrantfile: Fix vagrant environment lookup for admin nodes.

Revision Contents
Changeset List

PathSize
21 lines

Diff 24259

View Options

Vagrantfile

Loading...
About · Developer information · Legal