Page MenuHomeSoftware Heritage

Vagrantfile: Fix vagrant environment lookup for admin nodes
ClosedPublic

Authored by ardumont on Tue, Nov 23, 3:43 PM.

Details

Summary

The vagrant up instruction currently fails in trying to find a file which does not
exist. This is due to an environment declaration and branch mismatch.

This commit fixes it.

Related to P1220
Related to T3749

Test Plan

One of each environment's machine has been built to ensure everything is fine:

|-----------------------------+-------------+---------------+------------|
| Command                     | environment | without patch | with patch |
|-----------------------------+-------------+---------------+------------|
| `vagrant up admin-bardo`    | admin       | KO            | OK         |
| `vagrant up logstash` OK    | production  | OK            | OK         |
| `vagrant up staging-webapp` | staging     | OK            | OK         |
|-----------------------------+-------------+---------------+------------|

Diff Detail

Repository
rSENV Puppet Environment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.
ardumont edited the test plan for this revision. (Show Details)

Rename variable to something more sensible

vsellier added a subscriber: vsellier.

thanks for having fixed this

This revision is now accepted and ready to land.Tue, Nov 23, 5:23 PM